Fix 'double event' on windows crossterm read#27
Merged
Lutetium-Vanadium merged 1 commit intoLutetium-Vanadium:masterfrom Dec 2, 2025
Merged
Fix 'double event' on windows crossterm read#27Lutetium-Vanadium merged 1 commit intoLutetium-Vanadium:masterfrom
Lutetium-Vanadium merged 1 commit intoLutetium-Vanadium:masterfrom
Conversation
Owner
|
Hi, thanks for the PR! The change overall looks good, but I have a few questions regarding it that I can't test since I don't have a windows system.
|
Author
|
Owner
|
Ok, since the newline is a release event can we add the repeat event to the conditon. This is closest to the original code while fixing the bug, and there may be some combination of terminal emulator and operating system that returns repeat. |
Author
|
it is done |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #26. Can be observed via
cargo run --example inputon windows.