Add redis to docker compose #216
Conversation
|
Yes because the docker env are passed to Lychee via the inject.sh |
| #- APP_DEBUG=true | ||
| #- APP_FORCE_HTTPS=false | ||
| #- APP_URL=http://localhost | ||
| - APP_URL=${APP_URL:-http://localhost} |
There was a problem hiding this comment.
This is already the default - does this one not pass through?
There was a problem hiding this comment.
it makes it easier to modify in .env without having to fiddle in lychee/config/.env as misconfiguration of this value is the first cause of failure.
There was a problem hiding this comment.
But it's an env value, so wouldn't it work when modified in .env anyway?
There was a problem hiding this comment.
I thought the idea was that setting APP_URL in .env set the environment variable in the container rather than in the shell? Which would mean this should pass through without adding that line.
README.md
Outdated
| ## Table of Contents | ||
| <!-- TOC depthFrom:1 depthTo:6 withLinks:1 updateOnSave:1 orderedList:0 --> | ||
| - [Image content](#image-content) | ||
| - [Notice: Dockerhub repository has been migrated to lycheeorg/lychee](#notice-dockerhub-repository-has-been-migrated-to-lycheeorglychee) |
There was a problem hiding this comment.
At this point we can probably drop this notice.
| ## Advanced configuration | ||
|
|
||
| Note that nginx will accept by default images up to 100MB (`client_max_body_size 100M`) and that PHP parameters are overridden according to the [recommendations of the Lychee FAQ](https://lycheeorg.github.io/docs/faq.html#i-cant-upload-large-photos). | ||
|
|
||
| You may still want to further customize PHP configuration. The first method is to mount a custom `php.ini` to `/etc/php/8.2/fpm/php.ini` when starting the container. However, this method is kind of brutal as it will override all parameters. It will also need to be remapped whenever an image is released with a new version of PHP. | ||
|
|
||
| Instead, we recommend to use the `PHP_VALUE` directive of PHP-FPM to override specific parameters. To do so, you will need to mount a custom `nginx.conf` in your container : | ||
|
|
||
| 1. Take the [default.conf](./default.conf) file as a base | ||
| 2. Find the line starting by `fastcgi_param PHP_VALUE [...]` | ||
| 3. Add a new line and set your new parameter | ||
| 4. Add or change any other parameters (e.g. `client_max_body_size`) | ||
| 5. Mount your new file to `/etc/nginx/nginx.conf` | ||
|
|
||
| If you need to add (not change) nginx directives, files mounted in `/etc/nginx/conf.d/` will be included in the `http` context. | ||
|
|
There was a problem hiding this comment.
I was going to object to this, but I guess these overrides aren't really needed any more (unless someone really knows what they're doing, and so can figure it out easily enough).
There was a problem hiding this comment.
I thought about it, the main reason I am dropping it is because Lychee now supports upload by chunks, as a result the limit on post request is no longer an issue for large files. :)
Co-authored-by: Martin Stone <[email protected]>
No description provided.