Fix CD and release 6.3.0 #217
Conversation
d7415
left a comment
d7415
left a comment
There was a problem hiding this comment.
I wonder if other _PASSWORD variables need setting, but I think we set those to defaults now?
Either way, if tests (eventually) pass it works 🤷♂️
| - PUID=${PUID:-1000} | ||
| - PGID=${PGID:-1000} |
There was a problem hiding this comment.
Same query as with APP_URL in the other discussion.
There was a problem hiding this comment.
I am trying to look this one up.
https://docs.docker.com/compose/how-tos/environment-variables/set-environment-variables/
It is unclear to me whether the .env file is fully path through or if it is set for the docker compose which then use the environment definition... :|
There was a problem hiding this comment.
There was a problem hiding this comment.
I am indeed maybe a bit confused. Seems like indeed there is some difference behaviors...
There was a problem hiding this comment.
Hmm.. So we probably either need to enable more of those in docker-compose.yml or set .env as an env_file?
There was a problem hiding this comment.
Or use:
env_file:
- path: ./.env
required: false
nope. I checked. :) That's the only one without default. |
With the chance in the docker-compose this is obviously broken...