Skip to content

Do not crash Diagnostics on php-intl missing #3807

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ildyria merged 1 commit into from
Nov 15, 2025
Merged

Do not crash Diagnostics on php-intl missing #3807

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 18 additions & 11 deletions app/Models/Configs.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,20 +153,27 @@ public function sanity(?string $candidate_value, ?string $message_template = nul
}
break;
case ConfigType::CURRENCY->value:
$bundle = \ResourceBundle::create('en', 'ICUDATA-curr');
$currencies = $bundle->get('Currencies');
$found = false;
foreach ($currencies as $code => $data) {
$found = ($code === $candidate_value);
if ($found) {
break; // we found it, stop searching
try {
$bundle = \ResourceBundle::create('en', 'ICUDATA-curr');
$currencies = $bundle->get('Currencies');
$found = false;
foreach ($currencies as $code => $data) {
$found = ($code === $candidate_value);
if ($found) {
break; // we found it, stop searching
}
}
if (!$found) {
$message = sprintf($message_template, 'a valid ISO 4217 currency code');
break;
}
}
if (!$found) {
$message = sprintf($message_template, 'a valid ISO 4217 currency code');
break;
} catch (\Throwable) {
// @codeCoverageIgnoreStart
$message = 'php-intl extension is missing. Cannot validate currency code.';
break;
// @codeCoverageIgnoreEnd
}
break;
case ConfigType::MAP_PROVIDER->value:
if (MapProviders::tryFrom($candidate_value) === null) {
$message = sprintf($message_template, 'a valid map provider');
Expand Down