Update the file StabilityMatrix.Native.csproj so that the project can be debugged or run directly in the VisualStudio environment. #1045
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the .csproj file, the expression of $([System.Runtime.InteropServices.RuntimeInformation]...) is not a directly supported MSBuild expression. MSBuild does not support calling runtime APIs directly in <PropertyGroup>.
This results in the inability to directly debug or run the StabilityMatrix.Avalonia project after opening the project with VisualStudio.
Should be replaced by a RuntimeIdentifier based condition, for example:
<PropertyGroup Condition="'$(RuntimeIdentifier)' == 'win-x64'">
<IsWindows>true</IsWindows>
</PropertyGroup>
<PropertyGroup Condition="'$(RuntimeIdentifier)' == 'osx-x64' Or '$(RuntimeIdentifier)' == 'osx-arm64'">
<IsOSX>true</IsOSX>
</PropertyGroup>
<PropertyGroup Condition="'$(RuntimeIdentifier)' == 'linux-x64'">
<IsLinux>true</IsLinux>
</PropertyGroup>
|
CLA Assistant Lite bot CLA Assistant bot All Contributors have signed the CLA. |
Contributor
Author
|
I have read the CLA Document and I hereby sign the CLA |
ionite34
approved these changes
Dec 9, 2024
Member
ionite34
left a comment
ionite34
left a comment
There was a problem hiding this comment.
Yeah it seems using RuntimeIdentifier will be more consistent along with the main StabilityMatrix.Avalonia project that uses RuntimeIdentifier for resource bundling. Looks good, thank you!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the .csproj file, the expression of $([System.Runtime.InteropServices.RuntimeInformation]...) is not a directly supported MSBuild expression. MSBuild does not support calling runtime APIs directly in .
This results in the inability to directly debug or run the StabilityMatrix.Avalonia project after opening the project with VisualStudio.
Should be replaced by a RuntimeIdentifier based condition, for example:
true true true