add backup logic for sampler #1063
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ionite34
approved these changes
Jan 4, 2025
Member
|
Think something in GenerationParametersConverter might be better for being able to convert back, but I don't think we actually use the GenerationParameters for our own information (preferring inference json metadata) so this should be fine for now. Thanks for the PR! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added a backup logic for the sampler in case the requested sampler-schedule is not available in the ParamsToSamplerSchedulers to fix an issue the sampler won't be displayed properly in the name format.
(or would it be better to update the
GenerationParametersConverter.TryGetParametersitself?)