Skip to content

ComfyUI-Zluda: Exclude "Enable Manager" launch option from inherited options#1628

Open
NeuralFault wants to merge 5 commits intoLykosAI:mainfrom
NeuralFault:copilot/update-comfyui-zluda-launch-options
Open

ComfyUI-Zluda: Exclude "Enable Manager" launch option from inherited options#1628
NeuralFault wants to merge 5 commits intoLykosAI:mainfrom
NeuralFault:copilot/update-comfyui-zluda-launch-options

Conversation

@NeuralFault
Copy link
Copy Markdown
Contributor

This pull request makes a minor adjustment to the launch options for the ComfyZluda package. Specifically, it ensures that the "Enable Manager" option, in addition to "Cross Attention Method," is excluded from the inherited launch options.

  • Updated ComfyZluda.LaunchOptions to filter out both "Cross Attention Method" and "Enable Manager" from the base launch options.

ComfyUI-Zluda installs the custom_node-based version of the comfyui-manager as part of its install process, which requires no launch argument.
But because the ComfyUI configuration it inherits most of its not overidden launch options from uses the new comfyui-manager, its also has --enable-manager being automatically set for zluda installs. This leads to ComfyUI blocking initializing of the node-based one as policy when that launch argument is passed to it.
Leaving unaware users with broken manager functionality.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 2, 2026

CLA Assistant Lite bot:
Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.


I have read the CLA Document and I hereby sign the CLA


1 out of 2 committers have signed the CLA.
@NeuralFault
@copilot
You can retrigger this bot by commenting recheck in this Pull Request

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the ComfyZluda package model to exclude the 'Enable Manager' launch option from the base options. The review feedback recommends filtering by the technical command-line flag rather than the display name to prevent the logic from breaking if the display name is modified or localized.

Comment thread StabilityMatrix.Core/Models/Packages/ComfyZluda.cs
@NeuralFault NeuralFault marked this pull request as ready for review May 2, 2026 18:43
@NeuralFault
Copy link
Copy Markdown
Contributor Author

recheck

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants