ComfyUI-Zluda: Exclude "Enable Manager" launch option from inherited options#1628
ComfyUI-Zluda: Exclude "Enable Manager" launch option from inherited options#1628NeuralFault wants to merge 5 commits intoLykosAI:mainfrom
Conversation
…ions Agent-Logs-Url: https://github.com/NeuralFault/StabilityMatrix/sessions/fe293743-4768-41de-9e35-98ed0dd200b6 Co-authored-by: NeuralFault <65365345+NeuralFault@users.noreply.github.com>
|
CLA Assistant Lite bot: I have read the CLA Document and I hereby sign the CLA 1 out of 2 committers have signed the CLA. |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the ComfyZluda package model to exclude the 'Enable Manager' launch option from the base options. The review feedback recommends filtering by the technical command-line flag rather than the display name to prevent the logic from breaking if the display name is modified or localized.
|
recheck |
This pull request makes a minor adjustment to the launch options for the
ComfyZludapackage. Specifically, it ensures that the "Enable Manager" option, in addition to "Cross Attention Method," is excluded from the inherited launch options.ComfyZluda.LaunchOptionsto filter out both "Cross Attention Method" and "Enable Manager" from the base launch options.ComfyUI-Zluda installs the custom_node-based version of the comfyui-manager as part of its install process, which requires no launch argument.
But because the ComfyUI configuration it inherits most of its not overidden launch options from uses the new comfyui-manager, its also has --enable-manager being automatically set for zluda installs. This leads to ComfyUI blocking initializing of the node-based one as policy when that launch argument is passed to it.
Leaving unaware users with broken manager functionality.