Skip to content

feat(webgl): implement vertexAttribI4i, vertexAttribI4ui, vertexAttri… #399

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 3, 2025
Merged

feat(webgl): implement vertexAttribI4i, vertexAttribI4ui, vertexAttri… #399

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e165302
feat(webgl): implement vertexAttribI4i, vertexAttribI4ui, vertexAttri…
EndlessJour9527 Oct 28, 2025
b6c3d8f
Merge branch 'main' of github.com:M-CreativeLab/jsar-runtime into fea…
yorkie Nov 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
172 changes: 164 additions & 8 deletions src/client/script_bindings/webgl/webgl2_rendering_context.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1186,36 +1186,192 @@ namespace endor
{
Isolate *isolate = args.GetIsolate();
HandleScope scope(isolate);
Local<Context> context = isolate->GetCurrentContext();

isolate->ThrowException(Exception::Error(
MakeMethodError(isolate, "vertexAttribI4i", "Not implemented")));
if (args.Length() < 5)
{
isolate->ThrowException(Exception::TypeError(
MakeMethodArgCountError(isolate, "vertexAttribI4i", 5, args.Length())));
return;
}
for (int i = 0; i < 5; ++i)
{
if (!args[i]->IsNumber())
{
isolate->ThrowException(Exception::TypeError(
MakeMethodArgTypeError(isolate, "vertexAttribI4i", i, "number", args[i])));
return;
}
}

int index = args[0]->Int32Value(context).ToChecked();
int v0 = args[1]->Int32Value(context).ToChecked();
int v1 = args[2]->Int32Value(context).ToChecked();
int v2 = args[3]->Int32Value(context).ToChecked();
int v3 = args[4]->Int32Value(context).ToChecked();

handle()->vertexAttribI4i(index, v0, v1, v2, v3);
Comment on lines +1207 to +1213
Copy link

Copilot AI Oct 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The index parameter should be validated to ensure it's non-negative and within valid bounds (typically < MAX_VERTEX_ATTRIBS, usually 16 or 32 depending on implementation). Invalid index values could cause undefined behavior in the underlying OpenGL calls.

Copilot uses AI. Check for mistakes.
args.GetReturnValue().SetUndefined();
}

void WebGL2RenderingContext::VertexAttribI4ui(const v8::FunctionCallbackInfo<v8::Value> &args)
{
Isolate *isolate = args.GetIsolate();
HandleScope scope(isolate);
Local<Context> context = isolate->GetCurrentContext();

isolate->ThrowException(Exception::Error(
MakeMethodError(isolate, "vertexAttribI4ui", "Not implemented")));
if (args.Length() < 5)
{
isolate->ThrowException(Exception::TypeError(
MakeMethodArgCountError(isolate, "vertexAttribI4ui", 5, args.Length())));
return;
}
for (int i = 0; i < 5; ++i)
{
if (!args[i]->IsNumber())
{
isolate->ThrowException(Exception::TypeError(
MakeMethodArgTypeError(isolate, "vertexAttribI4ui", i, "number", args[i])));
return;
}
}

int index = args[0]->Int32Value(context).ToChecked();
uint32_t v0 = args[1]->Uint32Value(context).ToChecked();
uint32_t v1 = args[2]->Uint32Value(context).ToChecked();
uint32_t v2 = args[3]->Uint32Value(context).ToChecked();
uint32_t v3 = args[4]->Uint32Value(context).ToChecked();

Copy link

Copilot AI Oct 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The index parameter should be validated to ensure it's non-negative and within valid bounds (typically < MAX_VERTEX_ATTRIBS). This matches the validation pattern needed in vertexAttribI4i.

Suggested change
// Validate index parameter
constexpr int MAX_VERTEX_ATTRIBS = 16; // WebGL2 minimum, replace with actual value if available
if (index < 0 || index >= MAX_VERTEX_ATTRIBS) {
isolate->ThrowException(Exception::RangeError(
String::NewFromUtf8(isolate, "vertexAttribI4ui: index out of range").ToLocalChecked()));
return;
}

Copilot uses AI. Check for mistakes.
handle()->vertexAttribI4ui(index, v0, v1, v2, v3);
args.GetReturnValue().SetUndefined();
}

void WebGL2RenderingContext::VertexAttribI4iv(const v8::FunctionCallbackInfo<v8::Value> &args)
{
Isolate *isolate = args.GetIsolate();
HandleScope scope(isolate);
Local<Context> context = isolate->GetCurrentContext();

isolate->ThrowException(Exception::Error(
MakeMethodError(isolate, "vertexAttribI4iv", "Not implemented")));
if (args.Length() < 2)
{
isolate->ThrowException(Exception::TypeError(
MakeMethodArgCountError(isolate, "vertexAttribI4iv", 2, args.Length())));
return;
}
if (!args[0]->IsNumber())
{
isolate->ThrowException(Exception::TypeError(
MakeMethodArgTypeError(isolate, "vertexAttribI4iv", 0, "number", args[0])));
return;
}
if (!args[1]->IsInt32Array() && !args[1]->IsArray())
{
isolate->ThrowException(Exception::TypeError(
MakeMethodArgTypeError(isolate, "vertexAttribI4iv", 1, "Int32Array or Array", args[1])));
return;
}

int index = args[0]->Int32Value(context).ToChecked();
Copy link

Copilot AI Oct 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The index parameter should be validated to ensure it's non-negative and within valid bounds (typically < MAX_VERTEX_ATTRIBS). This validation is missing across all four methods.

Suggested change
int index = args[0]->Int32Value(context).ToChecked();
int index = args[0]->Int32Value(context).ToChecked();
// Validate index is non-negative and within bounds
constexpr int MAX_VERTEX_ATTRIBS = 16; // WebGL spec minimum, adjust if available from implementation
if (index < 0 || index >= MAX_VERTEX_ATTRIBS)
{
isolate->ThrowException(Exception::TypeError(
MakeMethodError(isolate, "vertexAttribI4iv", "index out of range")));
return;
}

Copilot uses AI. Check for mistakes.
std::vector<int> values;

if (args[1]->IsInt32Array())
{
auto data = args[1].As<Int32Array>();
auto arrayBuffer = data->Buffer();
if (arrayBuffer.IsEmpty())
{
isolate->ThrowException(Exception::TypeError(
MakeMethodError(isolate, "vertexAttribI4iv", "Invalid Int32Array")));
return;
}
auto bufferData = static_cast<int32_t *>(arrayBuffer->GetBackingStore()->Data()) + data->ByteOffset() / sizeof(int32_t);
values.assign(bufferData, bufferData + data->Length());
}
else
{
auto arr = args[1].As<Array>();
uint32_t length = arr->Length();
values.reserve(length);
for (uint32_t i = 0; i < length; ++i)
{
auto item = arr->Get(context, i).ToLocalChecked();
values.push_back(item->Int32Value(context).ToChecked());
}
}

if (values.size() < 4)
{
isolate->ThrowException(Exception::TypeError(
MakeMethodError(isolate, "vertexAttribI4iv", "Expected at least 4 components")));
return;
}

handle()->vertexAttribI4iv(index, values);
Copy link

Copilot AI Oct 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The index parameter should be validated to ensure it's non-negative and within valid bounds (typically < MAX_VERTEX_ATTRIBS). This validation is missing across all four methods.

Copilot uses AI. Check for mistakes.
args.GetReturnValue().SetUndefined();
}

void WebGL2RenderingContext::VertexAttribI4uiv(const v8::FunctionCallbackInfo<v8::Value> &args)
{
Isolate *isolate = args.GetIsolate();
HandleScope scope(isolate);
Local<Context> context = isolate->GetCurrentContext();

isolate->ThrowException(Exception::Error(
MakeMethodError(isolate, "vertexAttribI4uiv", "Not implemented")));
if (args.Length() < 2)
{
isolate->ThrowException(Exception::TypeError(
MakeMethodArgCountError(isolate, "vertexAttribI4uiv", 2, args.Length())));
return;
}
if (!args[0]->IsNumber())
{
isolate->ThrowException(Exception::TypeError(
MakeMethodArgTypeError(isolate, "vertexAttribI4uiv", 0, "number", args[0])));
return;
}
if (!args[1]->IsUint32Array() && !args[1]->IsArray())
{
isolate->ThrowException(Exception::TypeError(
MakeMethodArgTypeError(isolate, "vertexAttribI4uiv", 1, "Uint32Array or Array", args[1])));
return;
}

int index = args[0]->Int32Value(context).ToChecked();
Copy link

Copilot AI Oct 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The index parameter should be validated to ensure it's non-negative and within valid bounds (typically < MAX_VERTEX_ATTRIBS). This validation is missing across all four methods.

Copilot uses AI. Check for mistakes.
std::vector<uint32_t> values;

if (args[1]->IsUint32Array())
{
auto data = args[1].As<Uint32Array>();
auto arrayBuffer = data->Buffer();
if (arrayBuffer.IsEmpty())
{
isolate->ThrowException(Exception::TypeError(
MakeMethodError(isolate, "vertexAttribI4uiv", "Invalid Uint32Array")));
return;
}
auto bufferData = static_cast<uint32_t *>(arrayBuffer->GetBackingStore()->Data()) + data->ByteOffset() / sizeof(uint32_t);
values.assign(bufferData, bufferData + data->Length());
}
else
{
auto arr = args[1].As<Array>();
uint32_t length = arr->Length();
values.reserve(length);
for (uint32_t i = 0; i < length; ++i)
{
auto item = arr->Get(context, i).ToLocalChecked();
values.push_back(item->Uint32Value(context).ToChecked());
}
}

if (values.size() < 4)
{
isolate->ThrowException(Exception::TypeError(
MakeMethodError(isolate, "vertexAttribI4uiv", "Expected at least 4 components")));
return;
}

handle()->vertexAttribI4uiv(index, values);
Copy link

Copilot AI Oct 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The index parameter should be validated to ensure it's non-negative and within valid bounds (typically < MAX_VERTEX_ATTRIBS). This validation is missing across all four methods.

Copilot uses AI. Check for mistakes.
args.GetReturnValue().SetUndefined();
}

void WebGL2RenderingContext::GetUniformIndices(const FunctionCallbackInfo<Value> &args)
Expand Down