fix(join!)!: parsing NestedOrNot::Nested by removing needless Punctuated
#22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tuated` My initial implementation of `NestedOrNot` wrapped `Transformation` with `Punctuated`, but `Transformation` itself then expects items to be punctuated. This messed with the parser and made it think the field name was the quantity.
paolobarbolini
force-pushed
the
fix-nestedornot-transformation
branch
from
f9c1b5c to
c6965b2
Compare
paolobarbolini
changed the title
NestedOrNot::Nested by removing needless PunctuatedNestedOrNot::Nested by removing needless Punctuated
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My initial implementation of
NestedOrNotwrappedTransformationwithPunctuated, butTransformationitself then expects items to be punctuated. This messed with the parser and made it think the field name was the quantity.