Use private module to access external crates#9
Merged
paolobarbolini merged 3 commits intoM4SS-Code:mainfrom Jun 11, 2025
Merged
Use private module to access external crates#9paolobarbolini merged 3 commits intoM4SS-Code:mainfrom
paolobarbolini merged 3 commits intoM4SS-Code:mainfrom
Conversation
| /// Gets the actual [`Uuid`]. | ||
| /// | ||
| /// [`Uuid`]: ::uuid::Uuid | ||
| /// [`Uuid`]: $crate::__private::uuid::Uuid |
Member
There was a problem hiding this comment.
Shouldn't this be pointing at ::uuid::Uuid given that it's just docs?
Contributor
Author
There was a problem hiding this comment.
I checked this, it works flawlessly -- probably rustdoc is able to check that it should point to the original crate instead of the private module.
This is a screenshot of the doc of a dummy crate that only imports benzina (and it does not declare uuid in the deps)
Member
|
This will need to be rebased on top of |
dodomorandi
force-pushed
the
fix-crate-paths
branch
2 times, most recently
from
24d0c43 to
6a59f8d
Compare
In this way the macro works even if one of the crates is renamed to something else in the project that is using benzina.
We discovered that the derive macros of diesel tries to use the `diesel` crate name, which could have been omitted or renamed. Manually implementing the traits we can use our private path.
dodomorandi
force-pushed
the
fix-crate-paths
branch
from
6a59f8d to
75b3ecb
Compare
paolobarbolini
approved these changes
Jun 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just one doubt: should we also provide access toEDIT: ok, used the private module for thestdthrough$crate::__private?stdas well.Fixes #8