Skip to content

Conversation

@jamesmcroft
Copy link
Member

PR summary

This next addition for the WCT suite of control elements is for the Expander control providing support for expanding and collapsing content.

Tests have been added against the WCT sample application for this element.

This change has been made based on fix #3504 in the Windows Community Toolkit repo which is still in an open state. This PR should not be merged until that is completed.

PR checklist

  • Sample tests have been added/updated and pass
  • Code styling has been run on all new source file changes
  • Contains NO breaking changes

References

Resolves #21

@jamesmcroft jamesmcroft added the do not merge This PR should not be merged label Oct 3, 2020
@jamesmcroft jamesmcroft requested a review from a team October 3, 2020 18:09
@jamesmcroft jamesmcroft changed the title Added support for WCT Expander [WIP] Added support for WCT Expander Oct 3, 2020
@jamesmcroft jamesmcroft changed the title [WIP] Added support for WCT Expander 🚧 Added support for WCT Expander Oct 3, 2020
Copy link
Contributor

@tom-made tom-made left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy for these changes to be merged once the community toolkit bits are in 👍

@jamesmcroft jamesmcroft changed the title 🚧 Added support for WCT Expander Added support for WCT Expander Nov 2, 2020
@jamesmcroft jamesmcroft merged commit bd8232a into main Nov 2, 2020
@jamesmcroft jamesmcroft deleted the feature/wct-expander branch November 2, 2020 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do not merge This PR should not be merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature] WCT Expander element

3 participants