GH-631: Proof that it works on Actions (Don't Merge) #645
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* GH-601: introduce sent_payable table * GH-601: test that table with certain columns were created during migration * GH-601: resuse code to test fields of table * GH-601: migrate utils code * GH-601: trigger actions * GH-601: fix test constants_have_correct_values * GH-601: review changes * GH-601: move constant to database/test_utils.rs
…manily its DAO) (#617) * GH-608: change the trait object to support SentPayables * Revert "GH-608: change the trait object to support SentPayables" This reverts commit df415c0. * GH-608: introduce sent payable dao * GH-608: add boilerplate code * GH-608: implement insert_new_records * GH-608: add test cases for the panic and error clause for the insert method * GH-608: introduce builder pattern for the Tx * GH-608: implement get_tx_identifiers * GH-608: implement retrieve_pending_txs() * GH-608: add more assertions for the retrieve_pending_txs() and implement Display for TxStatus * GH-608: rename time_t in fn names to unix_timestamp * GH-608: refactor sent_payable_dao.rs * GH-608: add stronger tests for insert_new_records() * GH-608: retrieve txs conditionally * GH-608: change SQL to uppercase wherever necessary * GH-608: add RetrieveCondtion::ToRetry * GH-608: add constant RETRY_THRESHOLD_SECS * GH-608: implement display and from_str() for TxStatus * GH-608: implement retrieve_condition_display_works * GH-608: update the query for txs_to_retry and reorder trait functions * GH-608: change SQL query for txs to retry * GH-608: remove RETRY_THRESHOLD_SECS * GH-608: remove retried column from the sent_payable table * GH-608: add ability to retrieve tx by hash * GH-608: add the ability to update statuses * GH-608: add types for TxHash and RowID * GH-608: add test for deleting records * GH-608: add fn for deleting records * GH-608: add more TODOs * GH-608: error testing * GH-608: write tests for error handling while deleting records * GH-608: add more TODOs * GH-608: return SqlExecutionFailed in insert, change_status and delete operations * GH-608: add better error handling for delete records * GH-608: change the signature of delete_records() to accept Hashset * GH-608: remove unused SentPayableDaoError * GH-608: use the variant EmptyInput * GH-608: add more validations for insert_new_records * GH-608: test all errors * GH-608: remove unnecessary TODOs * GH-608: perform some cleanup * GH-608: eliminate clippy warnings * GH-608: review 1 changes * GH-608: remove clippy warnings * GH-608: review 2 changes
* GH-602: big bunch of changes * GH-602: interim commit * GH-602: four scans layout installed * GH-602: mostly done but still some crumbs of work left * GH-602: interim commit * GH-602: Recorder enriched by counter messages * GH-602: removed obfuscated and made right the formerly developed StopConditions * GH-602: removed obfuscated and made right the formerly developed StopConditions * GH-602: main part probably done * GH-602: more todos knocked off in accountant/mod.rs * GH-602: deep dive into schedulers and the awarness of the schedule state * GH-602: save point before going into fully private scanner * GH-602: another save point, this time before turning the scanner into fully private object * GH-602: finally fully scanners as flexible parametrized generic objects * GH-602: todos placed (many) as understood as the whole design * GH-602: more cases covered...knocking off todos!() continues * GH-602: made a markup for upcoming steps * GH-602: made a markup for upcoming steps * GH-602: Manual scanners prevented by the automation. Tested * GH-602: More tests written; mainly constraining the manual scanning * GH-602: before trying to implement the ScanScheduleHintErrorResolver * GH-602: tests for pending payable scanner and its start scan error resolver are compiling * GH-602: all tests in scan_schedulers passing now * GH-602: all tests in scan_schedulers passing now * GH-602: slowly fixing test in accountant/mod.rs * GH-602: fixed another couple of failing tests in accountant/mod.rs and scanners/mod.rs * GH-602: adding another little pile * GH-602: closing the gap... probably only one test to be written yet * GH-602: one more test written...ext tr. pen payable * GH-602: eliminated last todos in scanners/mod.rs * GH-602: first rough clean-up * GH-602: some comments fixed * GH-602: first piece of the review finished * GH-602: addressing review continues... * GH-602: addressing review continues on and on... * GH-602: more things for the review... * GH-602: last 6 comments to address * GH-602: finished the big two tests covering the very start of the automatic process with pp scanner playing the first violin * GH-602: huge tests refactored * GH-602: small functionalities made right and huge tests refactored * GH-602: prepared some fixes for early rescheduling * GH-602: moved the scanner test utils * GH-602: counter message summary comment added * GH-602: probably finished the minimm of what can be submitted seriously * GH-602: removed commented out impl * GH-602: vast majority of the review is covered * GH-602: refactoring in the biggeste tests - a la utkarsh * GH-602: review two ends * GH-602: improved comments --------- Co-authored-by: Bert <[email protected]>
utkarshg6
added a commit
that referenced
this pull request
Aug 3, 2025
utkarshg6
added a commit
that referenced
this pull request
Aug 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.