Skip to content

platform: alias strcasecmp to _stricmp on Windows#410

Closed
tomodachi94 wants to merge 1 commit intoMCJack123:masterfrom
tomodachi94:fix-windows-build-maybe
Closed

platform: alias strcasecmp to _stricmp on Windows#410
tomodachi94 wants to merge 1 commit intoMCJack123:masterfrom
tomodachi94:fix-windows-build-maybe

Conversation

@tomodachi94
Copy link
Contributor

@tomodachi94 tomodachi94 commented Dec 6, 2025

This fixes the build on Windows!

(At least, I think... I used GitHub Actions as my testing platform, and it fails on my fork with only an API key-related error, so I'm pretty confident that this change fixes the build.)

@MCJack123 MCJack123 closed this in 6d08b1c Dec 6, 2025
@MCJack123
Copy link
Owner

This code was copied from apis/config.cpp where it worked fine, so it was just missing an #include <cstring>. I also don't want to shadow standard library functions like that. Thanks for looking into the error regardless!

@tomodachi94 tomodachi94 deleted the fix-windows-build-maybe branch December 6, 2025 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants