Add flag check to allow f to be divisible by p#144
Open
Conversation
If you enter a superelliptic curve y^p = f(x), to ``SemistableModel`` the degree of f has to be prime to p for mclf to work correctly. Added a flag ``check`` in ``SuperpModels`` to override the error message. The following commits should add the code that treads this case correctly.
We added a comment in the notes to ``etale_locus`` explaining that the last changes are a hack. For a cleaner solution one would need a version of ``valuative_function`` where the domain is allowed to be an *open* discoid.
Contributor
Author
|
This branch is experimental. At the moment I can't guarantee that the computation of the semistable models works correctly if f is not prime to p. However, if |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If you enter a superelliptic curve
y^p = f(x),
to
SemistableModelthe degree of f has to beprime to p for mclf to work correctly.
Added a flag
checkinSuperpModelstooverride the error message.
The following commits should add the code that
treads this case correctly.