Skip to content

test in app builder encouraged in server card#1666

Open
ignaciojimenezr wants to merge 7 commits intomainfrom
action-based-cta
Open

test in app builder encouraged in server card#1666
ignaciojimenezr wants to merge 7 commits intomainfrom
action-based-cta

Conversation

@ignaciojimenezr
Copy link
Collaborator

@ignaciojimenezr ignaciojimenezr commented Mar 25, 2026

Screen.Recording.2026-03-24.at.10.33.32.PM.mov

@railway-app
Copy link

railway-app bot commented Mar 25, 2026

🚅 Environment inspector-pr-1666 in triumphant-alignment has no services deployed.

1 service not affected by this PR
  • mcp-inspector

@chelojimenez
Copy link
Contributor

chelojimenez commented Mar 25, 2026

Snyk checks have passed. No issues have been found so far.

Status Scan Engine Critical High Medium Low Total (0)
Open Source Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@ignaciojimenezr ignaciojimenezr marked this pull request as ready for review March 25, 2026 05:48
@dosubot dosubot bot added size:XL This PR changes 500-999 lines, ignoring generated files. enhancement New feature or request labels Mar 25, 2026
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 25, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 66cae5cd-9e02-44f7-b9fc-1c602aa2fc1a

📥 Commits

Reviewing files that changed from the base of the PR and between 0069520 and 6d2b333.

📒 Files selected for processing (4)
  • mcpjam-inspector/client/src/components/connection/shared/AuthenticationSection.tsx
  • mcpjam-inspector/client/src/components/mcp-sidebar.tsx
  • mcpjam-inspector/client/src/components/sidebar/nav-main.tsx
  • mcpjam-inspector/client/src/hooks/__tests__/use-ui-app-servers.test.tsx
✅ Files skipped from review due to trivial changes (1)
  • mcpjam-inspector/client/src/components/connection/shared/AuthenticationSection.tsx
🚧 Files skipped from review as they are similar to previous changes (2)
  • mcpjam-inspector/client/src/hooks/tests/use-ui-app-servers.test.tsx
  • mcpjam-inspector/client/src/components/mcp-sidebar.tsx

Walkthrough

This PR introduces a new hook, useUiAppServers, which asynchronously fetches per-server tool metadata with a 5s per-server timeout to derive appServerNames and resolvedServerNames. The sidebar App Builder "bubble" feature and its related props/state were removed. ServerConnectionCard gained onOpenAppBuilder and isUiCapabilityResolved props and a conditional "Test in app builder" action. ServersTab and App were updated to pass an onOpenAppBuilder callback that selects a server and navigates to the app-builder tab. Tests for the UI-capability resolution behavior were added.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
mcpjam-inspector/client/src/hooks/__tests__/use-ui-app-servers.test.tsx (1)

25-42: Migrate to the shared createServer() factory from client/src/test/factories.ts.

The test defines a local createServer() that duplicates the shared factory. Migrate to the shared factory and pass name as an override property rather than a positional parameter. Alternatively, use createConnectedServer() for test-specific defaults. This ensures fixture consistency across the codebase.

🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@mcpjam-inspector/client/src/hooks/__tests__/use-ui-app-servers.test.tsx`
around lines 25 - 42, Replace the local createServer factory with the shared
factory: remove the local function createServer and import the shared
createServer from the test factories file, calling it with an overrides object
that includes name (e.g. createServer({ name, ...otherOverrides })) instead of a
positional name arg; for tests that need the connected defaults use the shared
createConnectedServer helper (or pass connection-related overrides) so fixtures
remain consistent with ServerWithName and existing test factories.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Nitpick comments:
In `@mcpjam-inspector/client/src/hooks/__tests__/use-ui-app-servers.test.tsx`:
- Around line 25-42: Replace the local createServer factory with the shared
factory: remove the local function createServer and import the shared
createServer from the test factories file, calling it with an overrides object
that includes name (e.g. createServer({ name, ...otherOverrides })) instead of a
positional name arg; for tests that need the connected defaults use the shared
createConnectedServer helper (or pass connection-related overrides) so fixtures
remain consistent with ServerWithName and existing test factories.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: df8211c0-6c1f-4f59-8673-8790fe69e23b

📥 Commits

Reviewing files that changed from the base of the PR and between 74bc308 and 0069520.

📒 Files selected for processing (8)
  • mcpjam-inspector/client/src/App.tsx
  • mcpjam-inspector/client/src/components/ServersTab.tsx
  • mcpjam-inspector/client/src/components/connection/ServerConnectionCard.tsx
  • mcpjam-inspector/client/src/components/connection/__tests__/ServerConnectionCard.test.tsx
  • mcpjam-inspector/client/src/components/mcp-sidebar.tsx
  • mcpjam-inspector/client/src/components/sidebar/nav-main.tsx
  • mcpjam-inspector/client/src/hooks/__tests__/use-ui-app-servers.test.tsx
  • mcpjam-inspector/client/src/hooks/use-ui-app-servers.ts

@ignaciojimenezr ignaciojimenezr requested review from chelojimenez and prathmeshpatel and removed request for prathmeshpatel March 25, 2026 06:24
className="inline-flex items-center gap-1.5 rounded-full border border-border/70 bg-muted/30 px-2 py-0.5 text-[11px] text-foreground transition-colors hover:bg-accent/60 cursor-pointer"
>
<Rocket className="h-3 w-3" />
<span>Test in app builder</span>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<span>Test in app builder</span>
<span>Test in App Builder</span>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request size:XL This PR changes 500-999 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants