refactor #131 cards_abstracting_functionality#140
Open
samwatkinson1 wants to merge 3 commits intocards_abstracting_functionalityfrom
Open
refactor #131 cards_abstracting_functionality#140samwatkinson1 wants to merge 3 commits intocards_abstracting_functionalityfrom
samwatkinson1 wants to merge 3 commits intocards_abstracting_functionalityfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes for #131 to strongly type XCard members as the type of card they represent, e.g. Animal etc.
@mrmanc Let me know if this is on the right lines of what you were thinking for #131, I will update the other solutions as appropriate when you're happy (potentially
masterto updateAnimalclasses too) :)