Skip to content

Conversation

@IAlibay
Copy link
Member

@IAlibay IAlibay commented Nov 11, 2024

No description provided.

@codecov
Copy link

codecov bot commented Nov 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.60%. Comparing base (020b199) to head (ce43a23).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #139      +/-   ##
==========================================
+ Coverage   87.55%   87.60%   +0.05%     
==========================================
  Files           5        5              
  Lines         747      742       -5     
  Branches      127       96      -31     
==========================================
- Hits          654      650       -4     
  Misses         56       56              
+ Partials       37       36       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@IAlibay IAlibay requested a review from orbeckst November 11, 2024 17:49
Copy link
Member

@orbeckst orbeckst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume that the failures on 3.13 are because we do not have MDAnalysis at 3.13 yet?

Everything looks good in principle so I approve.

Thank you for the comprehensive update.

@orbeckst
Copy link
Member

@IAlibay please merge at will.

@IAlibay
Copy link
Member Author

IAlibay commented Nov 11, 2024

I assume that the failures on 3.13 are because we do not have MDAnalysis at 3.13 yet?

no.. it should be the other way around (griddataformats is a dependency of MDA) - I'll need to look at that more.

@IAlibay
Copy link
Member Author

IAlibay commented Nov 11, 2024

I think I remember this bug being that conda isn't aliased to micromamba for non-linux cases. Hopefully this fixes it.

@IAlibay
Copy link
Member Author

IAlibay commented Nov 11, 2024

Here we go, that does the trick - thanks for the review @orbeckst !

@IAlibay IAlibay merged commit 86a4109 into master Nov 11, 2024
@IAlibay IAlibay deleted the update-py13 branch November 11, 2024 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants