Skip to content

Conversation

@namiroues
Copy link
Contributor

This PR addresses #441.

Copy link
Contributor

@micaela-matta micaela-matta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks! looking good

Copy link
Member

@orbeckst orbeckst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this page needs to make clear that there's much more to the MDAnalysis Project than just the core library and the User Guide. Please see comments & please ask here (and in discord) if you want to bounce ideas.

@namiroues
Copy link
Contributor Author

Thanks @micaela-matta, @orbeckst and @RMeli for your comments. I redesigned the page based on your suggestions.

@namiroues namiroues requested a review from jennaswa March 15, 2025 08:48
@namiroues
Copy link
Contributor Author

Thanks @micaela-matta for your last comments. I've incorporated the changes.

@namiroues namiroues requested a review from micaela-matta March 18, 2025 21:06
Copy link
Member

@orbeckst orbeckst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The rewrite is really nice.

My remaining concerns are

  • We should mention that we have other code repos that are not MDAKits and there contributors are also welcome.
  • I am hesitant to include content in this page that needs updating. Someone has to (1) do it regularly (nobody does), (2)has to remember that content needs to be updated here (eg for GSoC, events). And when things are not being updated, the page feels stale sooner than strictly necessary. If there's a way to automate inclusion of content (e.g., based on tags in the meta data) then that would be neat, though.

@namiroues
Copy link
Contributor Author

Thanks @micaela-matta for your comments. I've updated the page.

@namiroues namiroues requested a review from micaela-matta March 21, 2025 17:32
Copy link
Member

@orbeckst orbeckst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is all looking very good. I have a bunch of suggestions and one technical request: use post_url liquid tags when referencing blog posts. This is necessary to generate reliably stable links.

@namiroues namiroues requested a review from orbeckst March 23, 2025 09:44
Copy link
Contributor

@micaela-matta micaela-matta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @namiroues - some last minor changes from me

@namiroues
Copy link
Contributor Author

Thanks @micaela-matta. I've made the changes.

@micaela-matta micaela-matta merged commit 1257283 into MDAnalysis:master Mar 27, 2025
1 check passed
@namiroues namiroues deleted the sdg23-add-contribute-page-md branch April 2, 2025 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

SDG23 work on Small Development Grant 2023

Development

Successfully merging this pull request may close these issues.

4 participants