-
Notifications
You must be signed in to change notification settings - Fork 47
Refined About, Mission, Governance, and Funding pages #451
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refined About, Mission, Governance, and Funding pages #451
Conversation
|
If Governance gets changed, you need reviews from @MDAnalysis/coredevs . |
orbeckst
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the restructuring. Touching Mission and Governance is sensitive and we cannot simply change of these. Please see comments.
jennaswa
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for organizing this page, @namiroues . In addition to Micaela and Oliver's comments, I have a few more suggestions.
| ## Open Source & Availability | ||
|
|
||
| ## Open source | ||
| MDAnalysis is released under the [GNU Lesser General Public License, version 2.1 or later (LGPLv2.1+)][]. This ensures that our tools remain accessible, transparent, and reproducible for molecular dynamics research. Some supporting libraries use the MIT or BSD-3 licenses. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there still a line somewhere about teaching materials being open source (I think most are probably cc-by licenses)? As with Oliver's comment about the mission statement, it is our goal to be open as a project, not just related specifically to the library.
|
Thanks @micaela-matta, @orbeckst and @jennaswa for your comments. I made the changes. There are a couple of comments that I made a note of, to ask for clarification in our meeting (nothing major though). |
orbeckst
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good with me.
I'd consider moving mission.md to the top level (because you're creating a new page so we could it do right now and change the links to it in the same PR). We might also want to move some of the other important pages to the top level — basically anything that shows up in the menu.
jennaswa
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, @namiroues - thanks! Just a few minor non-blocking suggestions.
|
Thanks @jennaswa for your comments. I've incorporated the changes. |
This PR addresses #441.