Skip to content

Conversation

@namiroues
Copy link
Contributor

@namiroues namiroues commented Mar 14, 2025

This PR addresses #441.

Copy link
Contributor

@micaela-matta micaela-matta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking so much better!

@namiroues
Copy link
Contributor Author

Thanks @micaela-matta and @orbeckst. I addressed your comments. I rewrote the first paragraph and tried to follow all suggestions.

Copy link
Member

@orbeckst orbeckst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the rewrite. This is all hitting the right tone and is a massive improvement.

I have a number of change requests, please see inline.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this blog post part of this PR? Perhaps rebase against master?

@namiroues namiroues force-pushed the sdg23-update-index-page branch from 36e6586 to a55c140 Compare March 23, 2025 15:39
@namiroues namiroues requested review from RMeli and orbeckst March 23, 2025 15:40
@namiroues
Copy link
Contributor Author

Thanks @orbeckst and @RMeli for your comments. I've updated the page.

Copy link
Member

@orbeckst orbeckst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, the long over-due rewrite of the landing page!

@micaela-matta micaela-matta merged commit 9b4b76f into MDAnalysis:master Mar 25, 2025
1 check passed
@namiroues namiroues deleted the sdg23-update-index-page branch April 2, 2025 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

SDG23 work on Small Development Grant 2023

Development

Successfully merging this pull request may close these issues.

4 participants