Skip to content

Conversation

@namiroues
Copy link
Contributor

This PR addresses #441.

Copy link
Contributor

@micaela-matta micaela-matta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

Copy link
Member

@orbeckst orbeckst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for digging into this page, there are two majors oversights on it where we didn't update properly in the past

  • LGPL for MDA
  • logo cannot be used outside MDA anymore

Could you please incorporated these changes?

@jennaswa
Copy link
Contributor

Thanks, @namiroues ! Once Micaela and Oliver's comments are addressed, all LGTM :)

@namiroues namiroues force-pushed the sdg23-update-citations branch from ec9a558 to 6ceef2d Compare March 17, 2025 21:20
Copy link
Member

@RMeli RMeli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM.

A small comment: it seems that you condensed multiple lines into a single line. In general, when working with git, I think it is beneficial to have a newline for every phrase or every at some punctuations, because it makes changes more localized thus reducing the chances of git conflicts. It also plays better with git blame.

Nothing to change here, just something to potentially keep in ming going forward.

Co-authored-by: Rocco Meli <[email protected]>
@namiroues
Copy link
Contributor Author

Thanks @micaela-matta, @orbeckst and @RMeli for your comments. All addressed now.

@namiroues namiroues requested a review from micaela-matta March 18, 2025 18:24
@namiroues
Copy link
Contributor Author

Thanks @micaela-matta, I corrected this.

@namiroues namiroues requested a review from micaela-matta March 19, 2025 17:41
@micaela-matta
Copy link
Contributor

@jennaswa let me know if it's all good for you and I'll merge this.

@micaela-matta micaela-matta merged commit 9784b3b into MDAnalysis:master Mar 27, 2025
1 check passed
@namiroues namiroues deleted the sdg23-update-citations branch April 2, 2025 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

SDG23 work on Small Development Grant 2023

Development

Successfully merging this pull request may close these issues.

5 participants