-
Notifications
You must be signed in to change notification settings - Fork 47
update citations page #456
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update citations page #456
Conversation
micaela-matta
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks!
orbeckst
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for digging into this page, there are two majors oversights on it where we didn't update properly in the past
- LGPL for MDA
- logo cannot be used outside MDA anymore
Could you please incorporated these changes?
|
Thanks, @namiroues ! Once Micaela and Oliver's comments are addressed, all LGTM :) |
ec9a558 to
6ceef2d
Compare
RMeli
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, LGTM.
A small comment: it seems that you condensed multiple lines into a single line. In general, when working with git, I think it is beneficial to have a newline for every phrase or every at some punctuations, because it makes changes more localized thus reducing the chances of git conflicts. It also plays better with git blame.
Nothing to change here, just something to potentially keep in ming going forward.
Co-authored-by: Rocco Meli <[email protected]>
|
Thanks @micaela-matta, @orbeckst and @RMeli for your comments. All addressed now. |
|
Thanks @micaela-matta, I corrected this. |
|
@jennaswa let me know if it's all good for you and I'll merge this. |
This PR addresses #441.