Turn on carbon_kh test case (#522)

evbauer · web-flow · commit 34ffaae5a72a · 2023-04-04T13:00:37.000-04:00
Test runs the high resolution time-centered `eps_grav` case from the convergence study of MESA VI.
diff --git a/star/test_suite/carbon_kh/README.rst b/star/test_suite/carbon_kh/README.rst
@@ -24,6 +24,19 @@ non-degenerate conditions to conditions of relativistic electron
 degeneracy and the dominant energy loss mechanism transitions from
 radiative diffusion to optically-thin neutrino cooling.
 
+This case is discussed extensively in section 5.2 of
+`MESA Instrument Paper VI <https://ui.adsabs.harvard.edu/abs/2023ApJS..265...15J/abstract>`__.
+You can run the full resolution study described in that section by
+using the ``rnall`` bash script, which links to different energy equation
+and resolution options to run through the model 12 times. This will produce
+the output necessary for reproducing plots like the ones below and seen in
+figures 9 and 10 of the instrument paper.
+
+By default, the test suite ``rn`` script runs just one of these instances:
+the high resolution run using the ``eps_grav`` energy equation option,
+which should run in a few minutes, appears reasonably converged based on the plots
+below, and exhibits a small cumulative energy error.
+
 The included Jupyter notebook (``docs/carbon_kh.ipynb``) provides
 information about reproducing the following convergence study.
 
@@ -34,5 +47,5 @@ information about reproducing the following convergence study.
 .. image:: ../../../star/test_suite/carbon_kh/docs/carbon_kh_total_energy_history_with_rel_cum_E_err.png
 
 
-Last-Updated: 2021-08-26 (mesa e9d467610) by Josiah Schwab
+Last-Updated: 2023-04-03 (mesa 81ad921) by Evan Bauer
 
diff --git a/star/test_suite/carbon_kh/inlist_carbon_kh b/star/test_suite/carbon_kh/inlist_carbon_kh
@@ -4,6 +4,10 @@
   load_saved_model = .true.
   load_model_filename = 'pure_carbon_at_rhoc_10gcc.mod'
 
+  save_model_when_terminate = .true.
+  save_model_filename = 'final.mod'
+  required_termination_code_string = 'log_center_density_limit'
+
   set_initial_age = .true.
   initial_age = 0
 
@@ -65,9 +69,9 @@
 
   history_interval = 1
   write_profiles_flag = .true.
-  profile_interval = 1000000000
-  photo_interval = 1000000000
-  terminal_interval = 10 
+  profile_interval = 10000
+  photo_interval = 100
+  terminal_interval = 10
 
   num_trace_history_values = 2
   trace_history_value_name(1) = 'rel_E_err'
@@ -76,10 +80,10 @@
   use_gold2_tolerances = .true.
 
   ! for convergence studies
-      read_extra_controls_inlist(2) = .false.
+      read_extra_controls_inlist(2) = .true.
       extra_controls_inlist_name(2)= 'inlist_resolution'
 
-      read_extra_controls_inlist(3) = .false.
+      read_extra_controls_inlist(3) = .true.
       extra_controls_inlist_name(3)= 'inlist_equations'
 
 / ! end of controls namelist
diff --git a/star/test_suite/carbon_kh/inlist_equations b/star/test_suite/carbon_kh/inlist_equations
@@ -0,0 +1 @@
+inlists/inlist_eps_grav
diff --git a/star/test_suite/carbon_kh/inlist_resolution b/star/test_suite/carbon_kh/inlist_resolution
@@ -0,0 +1 @@
+inlists/inlist_hr
diff --git a/star/test_suite/carbon_kh/inlists/inlist_eps_grav b/star/test_suite/carbon_kh/inlists/inlist_eps_grav
@@ -1,6 +1,7 @@
 &controls
 
       energy_eqn_option = 'eps_grav'
+      use_time_centered_eps_grav = .true.
 
 ! turn off energy error related things
       limit_for_rel_error_in_energy_conservation = 1d99
diff --git a/star/test_suite/carbon_kh/inlists/inlist_eps_grav_old b/star/test_suite/carbon_kh/inlists/inlist_eps_grav_old
@@ -1,7 +1,7 @@
 &controls
 
       energy_eqn_option = 'eps_grav'
-      use_time_centered_eps_grav = .true.
+      use_time_centered_eps_grav = .false.
 
 ! turn off energy error related things
       limit_for_rel_error_in_energy_conservation = 1d99
diff --git a/star/test_suite/carbon_kh/inlists/inlist_hr b/star/test_suite/carbon_kh/inlists/inlist_hr
@@ -6,4 +6,7 @@
 
   terminal_interval = 100
 
+  ! limit max_model_number as part of test_suite
+  max_model_number = 4000
+
 / ! end of controls namelist
diff --git a/star/test_suite/carbon_kh/rnall b/star/test_suite/carbon_kh/rnall
@@ -17,6 +17,6 @@ do_set(){
 }
 
 do_set dedt_total
+do_set eps_grav_old
 do_set eps_grav
-do_set eps_grav_future
 
diff --git a/star/test_suite/carbon_kh/standard_pure_carbon_at_rhoc_10gcc.mod b/star/test_suite/carbon_kh/standard_pure_carbon_at_rhoc_10gcc.mod
diff --git a/star/test_suite/do1_test_source b/star/test_suite/do1_test_source
@@ -26,6 +26,7 @@ do_one 16M_predictive_mix "termination code: xa_central_lower_limit" "tams.mod"
 do_one 20M_z2m2_high_rotation "stop because have dropped below central lower limit for he4" "final.mod" auto
 do_one accreted_material_j "star_mass_max_limit" "final.mod" auto
 do_one adjust_net "finished with expected number of species" "final.mod" auto
+do_one carbon_kh "stop because log_center_density >= log_center_density_limit" "final.mod" auto
 do_one cburn_inward "Terminate as flame reached half way" "final.mod" auto
 do_one check_pulse_atm "all values are within tolerance" "final.mod" skip
 do_one check_redo "stop because have dropped below central lower limit for h1" "final.mod" auto

Original file line number	Diff line number	Diff line change
`@@ -17,6 +17,6 @@ do_set(){`
`17`	`17`	`}`
`18`	`18`
`19`	`19`	`do_set dedt_total`
	`20`	`+do_set eps_grav_old`
`20`	`21`	`do_set eps_grav`
`21`		`-do_set eps_grav_future`
`22`	`22`