Updating to save b% dt value during binary timestep #845
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempting to resolve the behavior mentioned in #556 (b% dt not set in binary module). Previously, b% dt and b% dt_old remain set to 0, and are simply passed back and forth in private/binary_evolve.f90. Additionally, b% dt was not used to drive the dt's in the relevant star pointers (dt_min is used instead).
This commit just casts that dt_min over into the binary pointer. It also simplifies the use of dt_reduction_factor_for_j, assuming the dt's for any star in the binary must be the same.