Skip to content

Conversation

@roanutil
Copy link
Member

No description provided.

feature/update-workflow
feature/update-workflow
feature/update-workflow
@codecov
Copy link

codecov bot commented Apr 18, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.38%. Comparing base (b2660f3) to head (f55ba61).

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #16      +/-   ##
==========================================
- Coverage   82.11%   81.38%   -0.73%     
==========================================
  Files          23       23              
  Lines        1118     1418     +300     
==========================================
+ Hits          918     1154     +236     
- Misses        200      264      +64     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@r-jarvis r-jarvis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to update // swift-tools-version: 5.8 at the top of Pacakge.swift to use Swift 6?

@roanutil
Copy link
Member Author

Do we need to update // swift-tools-version: 5.8 at the top of Pacakge.swift to use Swift 6?

I don't think so? Why would we need to?

@r-jarvis
Copy link
Contributor

Do we need to update // swift-tools-version: 5.8 at the top of Pacakge.swift to use Swift 6?

I don't think so? Why would we need to?

We removed the conditional swift version support in Tests/ArgumentEncodingTests/ArgumentGroupTests.swift. I assumed you were doing that because we were now requiring Swift 6.

@roanutil
Copy link
Member Author

Do we need to update // swift-tools-version: 5.8 at the top of Pacakge.swift to use Swift 6?

I don't think so? Why would we need to?

We removed the conditional swift version support in Tests/ArgumentEncodingTests/ArgumentGroupTests.swift. I assumed you were doing that because we were now requiring Swift 6.

Oh, no. I'm guessing that was for a bug in a pre-release version of Swift 6. It tested as working in release versions of 5.8 and 6.0 after being removed.

@roanutil roanutil closed this Apr 21, 2025
@roanutil roanutil reopened this Apr 21, 2025
@r-jarvis r-jarvis merged commit 0ec6b15 into main Apr 21, 2025
9 of 10 checks passed
@roanutil roanutil deleted the feature/update-workflow branch April 21, 2025 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants