Bug fix for CFL adaptive time stepping

[wilfonba]

User description

Description

Bug fix for CFL adaptive time stepping. The denominators should be maxval not minval in order to capture the worst case. Thanks to Mike VandenBoom for pointing this error out to me.

Type of change

Please delete options that are not relevant.

• Bug fix (non-breaking change which fixes an issue)

Scope

• This PR comprises a set of related changes with a common goal

---

PR Type

Bug fix

---

Description

• Fix CFL adaptive time stepping denominator calculation

• Change minval to maxval for worst-case scenario

• Affects 3D, 2D, and 1D viscous flow calculations

---

Diagram Walkthrough

flowchart LR
  A["CFL Time Stepping<br/>Viscous Calculations"] -->|"Replace minval<br/>with maxval"| B["Worst-case<br/>Denominator"]
  B --> C["Corrected dt<br/>Calculation"]

Loading

File Walkthrough

	Relevant files
Bug fix	m_sim_helpers.fpp Replace minval with maxval in viscous CFL calculations      src/simulation/m_sim_helpers.fpp Changed minval(1/(rho*Re_l)) to maxval(1/(rho*Re_l)) in 3D viscous case Changed minval(1/(rho*Re_l)) to maxval(1/(rho*Re_l)) in 1D viscous case Ensures worst-case scenario is captured for CFL stability criterion +3/-3

---

[qodo-merge-pro]

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪

🧪 No relevant tests

🔒 No security concerns identified

⚡ Recommended focus areas for review Possible Issue Mixed use of maxval with differently arranged expressions could lead to inconsistent behavior across dimensions; verify that 2D path using maxval((1/Re_l)/rho) is equivalent to maxval(1/(rho*Re_l)) and that all arrays share the same masking/shape context. vcfl_dt = cfl_target*(min(dx(j), dy(k))**2._wp)/maxval((1/Re_l)/rho) else !1D vcfl_dt = cfl_target*(dx(j)**2._wp)/maxval(1/(rho*Re_l)) end if Numerical Stability Division by maxval(1/(rhoRe_l)) can blow up if rhoRe_l approaches zero; ensure lower bounds or safeguards (e.g., eps floor) are applied to avoid inf or NaN time steps. vcfl_dt = cfl_target*(min(dx(j), dy(k), fltr_dtheta)**2._wp) & /maxval(1/(rho*Re_l)) else vcfl_dt = cfl_target*(min(dx(j), dy(k), dz(l))**2._wp) & /maxval(1/(rho*Re_l)) end if elseif (n > 0) then !2D vcfl_dt = cfl_target*(min(dx(j), dy(k))**2._wp)/maxval((1/Re_l)/rho) else !1D vcfl_dt = cfl_target*(dx(j)**2._wp)/maxval(1/(rho*Re_l)) end if

[qodo-merge-pro]

Suggestion: Prevent a potential division-by-zero error by adding a small epsilon value to the denominator rho*Re_l inside the maxval function call. [possible issue, importance: 8]

Suggested change

	vcfl_dt = cfl_target*(min(dx(j), dy(k), fltr_dtheta)**2._wp) &
	/minval(1/(rho*Re_l))
	/maxval(1/(rho*Re_l))
	vcfl_dt = cfl_target*(min(dx(j), dy(k), fltr_dtheta)**2._wp) &
	/maxval(1/(rho*Re_l + epsilon(0.0_wp)))

[Copilot]

Pull Request Overview

This PR corrects the viscous CFL time-step calculation for 1D and 3D cases by changing minval to maxval when computing the kinematic viscosity term, ensuring consistency with the 2D case and the inverse stability calculation in s_compute_stability_from_dt.

• Fixes incorrect use of minval to maxval for viscous CFL calculations
• Ensures consistent physics across all dimensionalities (1D, 2D, 3D)
• Aligns with the inverse calculation in s_compute_stability_from_dt

[codecov]

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 46.02%. Comparing base (bfd732c) to head (56396aa).
⚠️ Report is 2 commits behind head on master.

Files with missing lines	Patch %	Lines
src/simulation/m_sim_helpers.fpp	0.00%	1 Missing ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #1027   +/-   ##
=======================================
  Coverage   46.02%   46.02%           
=======================================
  Files          67       67           
  Lines       13437    13437           
  Branches     1550     1550           
=======================================
  Hits         6185     6185           
  Misses       6362     6362           
  Partials      890      890           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.