-
Notifications
You must be signed in to change notification settings - Fork 121
fix homebrew a bit #1047
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix homebrew a bit #1047
Conversation
|
You have run out of free Bugbot PR reviews for this billing cycle. This will reset on December 8. To receive reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial. |
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
PR Code Suggestions ✨No code suggestions found for the PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR fixes the Homebrew formula test to use the correct command-line syntax for the MFC wrapper. The Homebrew wrapper uses a simplified interface where users run mfc <case.py> directly, without the "run" subcommand that's used in the full ./mfc.sh developer interface.
Key Change
- Corrected the test invocation from
mfc run case.pytomfc case.py, aligning with the Homebrew wrapper's documented behavior
User description
homebrew fixes
PR Type
Bug fix
Description
Remove "run" subcommand from mfc test invocation
Simplify test case execution in Homebrew formula
Diagram Walkthrough
File Walkthrough
mfc.rb
Remove run subcommand from mfc testpackaging/homebrew/mfc.rb
block
system bin/"mfc", "run", "case.py", "-j", "1"tosystembin/"mfc", "case.py", "-j", "1"file