Skip to content

Conversation

@wilfonba
Copy link
Collaborator

@wilfonba wilfonba commented Oct 16, 2024

Description

Fixes a bug in the Delta template file that made it incompatible with case file command line options introduced in #338 when this file was first created. I'm guessing this hadn't been caught since using command line arguments in case files isn't particularly common.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Scope

  • This PR comprises a set of related changes with a common goal

How Has This Been Tested?

Successfully submitted job with case file command line options on Delta.

@sbryngelson
Copy link
Member

Fair enough though I think you tagged the wrong PR?

@wilfonba
Copy link
Collaborator Author

Corrected

@sbryngelson sbryngelson merged commit ecdf5b1 into MFlowCode:master Oct 16, 2024
11 of 13 checks passed
@henryleberre
Copy link
Member

That's right @wilfonba. The -- actually used to forward arguments to the mpirun/srun/... command and not the case file.. The template files did away with this terrible idea.

okBrian pushed a commit to okBrian/MFC that referenced this pull request Oct 18, 2024
Co-authored-by: Benjamin Wilfong <[email protected]>
@wilfonba wilfonba deleted the bugFixes branch November 5, 2024 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants