Fix indexing bug in surface tension #670
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbryngelson
approved these changes
Nov 1, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #670 +/- ##
=======================================
Coverage 54.53% 54.53%
=======================================
Files 61 61
Lines 13802 13802
Branches 1727 1727
=======================================
Hits 7527 7527
Misses 5819 5819
Partials 456 456 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A mixup in the ordering in variable allocation in surface tension meant that it would only work if m, n, and p were the same in 3D.
Fixes #663
Type of change
Please delete options that are not relevant.
Scope
How Has This Been Tested?
Ran a 3D case with surface tension on multiple processes where each process' local m, n, and p were not the same. Existing test cases passed, but they also weren't affected by this bug.