Skip to content

Cleanliness CI Fix Error & Now Can't error outside of build #691

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 5, 2024
Merged

Cleanliness CI Fix Error & Now Can't error outside of build #691

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4165004
fix cleanliness CI
okBrian Nov 5, 2024
a1cca9a
fix cleanliness
okBrian Nov 5, 2024
afac684
added true rather than error-on-continue
okBrian Nov 5, 2024
acf4e65
revert true change
okBrian Nov 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 13 additions & 8 deletions .github/workflows/cleanliness.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,42 +34,48 @@ jobs:
sed -i '/\/master\//d' master.txt

- name: Unused Variables Diff
continue-on-error: true
run: |
grep -F 'Wunused-variable' master.txt > mUnused.txt
grep -F 'Wunused-variable' pr.txt > prUnused.txt
diff prUnused.txt mUnused.txt || true
diff prUnused.txt mUnused.txt

- name: Unused Dummy Arguments Diff
continue-on-error: true
run: |
grep -F 'Wunused-dummy-argument' pr.txt > prDummy.txt
grep -F 'Wunused-dummy-argument' pr.txt > prDummy.txt
grep -F 'Wunused-dummy-argument' master.txt > mDummy.txt
diff prDummy.txt mDummy.txt || true
diff prDummy.txt mDummy.txt

- name: Unused Value Diff
continue-on-error: true
run: |
grep -F 'Wunused-value' pr.txt > prUnused_val.txt
grep -F 'Wunused-value' master.txt > mUnused_val.txt
diff prUnused_val.txt mUnused_val.txt || true
diff prUnused_val.txt mUnused_val.txt

- name: Maybe Uninitialized Variables Diff
continue-on-error: true
run: |
grep -F 'Wmaybe-uninitialized' pr.txt > prMaybe.txt
grep -F 'Wmaybe-uninitialized' master.txt > mMaybe.txt
diff prMaybe.txt mMaybe.txt || true
diff prMaybe.txt mMaybe.txt


- name: Everything Diff
continue-on-error: true
run: |
grep '\-W' pr.txt > pr_every.txt
grep '\-W' pr.txt > pr_every.txt
grep '\-W' master.txt > m_every.txt
diff pr_every.txt m_every.txt || true
diff pr_every.txt m_every.txt

- name: List of Warnings
run: |
cat pr_every.txt


- name: Summary
continue-on-error: true
run: |
pr_variable=$(grep -c -F 'Wunused-variable' pr.txt)
pr_argument=$(grep -c -F 'Wunused-dummy-argument' pr.txt)
Expand Down Expand Up @@ -100,6 +106,5 @@ jobs:
if: env.pr_everything > env.master_everything
run: |
echo "Difference between warning count in PR is greater than in master."
exit 1


Loading