Skip to content

Conversation

@wilfonba
Copy link
Collaborator

@wilfonba wilfonba commented Nov 7, 2024

Description

This case file failed as the resolution was increased because the rectangular patches did not cover the entire stretched domain in the y direction.

Fixes #(issue) [optional]

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Scope

  • This PR comprises a set of related changes with a common goal

@wilfonba wilfonba requested a review from sbryngelson as a code owner November 7, 2024 21:24
@codecov
Copy link

codecov bot commented Nov 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 43.04%. Comparing base (39e410a) to head (a13e932).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #705   +/-   ##
=======================================
  Coverage   43.04%   43.04%           
=======================================
  Files          61       61           
  Lines       16062    16062           
  Branches     1798     1798           
=======================================
  Hits         6914     6914           
  Misses       8158     8158           
  Partials      990      990           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sbryngelson sbryngelson merged commit 4396130 into MFlowCode:master Nov 8, 2024
21 of 23 checks passed
@VaLiuqqq
Copy link

if it is 14D, then the y_centroid is 7D not 6*D.

@sbryngelson
Copy link
Member

if it is 14_D, then the y_centroid is 7_D not 6*D.

@wilfonba

@wilfonba
Copy link
Collaborator Author

if it is 14_D, then the y_centroid is 7_D not 6*D.

@wilfonba

The actual value doesn't matter as long as the patch covers the entire grid in the y direction.

@wilfonba wilfonba deleted the bugFixes branch April 19, 2025 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants