-
Notifications
You must be signed in to change notification settings - Fork 121
Fix 2D_shockdroplet example case #705
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #705 +/- ##
=======================================
Coverage 43.04% 43.04%
=======================================
Files 61 61
Lines 16062 16062
Branches 1798 1798
=======================================
Hits 6914 6914
Misses 8158 8158
Partials 990 990 ☔ View full report in Codecov by Sentry. |
|
if it is 14D, then the y_centroid is 7D not 6*D. |
|
The actual value doesn't matter as long as the patch covers the entire grid in the y direction. |
Description
This case file failed as the resolution was increased because the rectangular patches did not cover the entire stretched domain in the y direction.
Fixes #(issue) [optional]
Type of change
Please delete options that are not relevant.
Scope