Skip to content

Update benchmark batch script for one submission per device #795

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from
Closed

Update benchmark batch script for one submission per device #795

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
921b878
Update submit-bench.sh
sbryngelson Jan 27, 2025
0ef1860
Update bench.yml
sbryngelson Jan 27, 2025
b416ac4
Update submit-bench.sh
sbryngelson Jan 27, 2025
3e96acd
Update bench.yml
sbryngelson Jan 27, 2025
b1c6d0f
Update submit-bench.sh
sbryngelson Jan 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions .github/workflows/bench.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,9 +47,7 @@ jobs:

- name: Bench (Master v. PR)
run: |
(cd pr && bash .github/workflows/phoenix/submit-bench.sh .github/workflows/phoenix/bench.sh ${{ matrix.device }}) &
(cd master && bash .github/workflows/phoenix/submit-bench.sh .github/workflows/phoenix/bench.sh ${{ matrix.device }}) &
wait %1 && wait %2
(cd pr && bash .github/workflows/phoenix/submit-bench.sh .github/workflows/phoenix/bench.sh ${{ matrix.device }})

- name: Generate & Post Comment
run: |
Expand Down
21 changes: 19 additions & 2 deletions .github/workflows/phoenix/submit-bench.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,11 +20,13 @@ sbatch_cpu_opts="\
"

sbatch_gpu_opts="\
#SBATCH -CV100
#SBATCH -p gpu-v100
#SBATCH --ntasks-per-node=4 # Number of cores per node required
#SBATCH -G2\
"

# ,gpu-a100,gpu-h100,gpu-h200,gpu-l40s

if [ "$2" == "cpu" ]; then
sbatch_device_opts="$sbatch_cpu_opts"
elif [ "$2" == "gpu" ]; then
Expand All @@ -42,7 +44,7 @@ sbatch <<EOT
#SBATCH --account=gts-sbryngelson3 # charge account
#SBATCH -N1 # Number of nodes required
$sbatch_device_opts
#SBATCH -t 02:00:00 # Duration of the job (Ex: 15 mins)
#SBATCH -t 04:00:00 # Duration of the job (Ex: 15 mins)
#SBATCH -q embers # QOS Name
#SBATCH -o$job_slug.out # Combined output and error messages file
#SBATCH -W # Do not exit until the submitted job terminates.
Expand All @@ -51,6 +53,21 @@ set -e
set -x

cd "\$SLURM_SUBMIT_DIR"
echo "Running PR"

echo "Running in $(pwd):"

job_slug="$job_slug"
job_device="$2"

. ./mfc.sh load -c p -m $2

$sbatch_script_contents

cd "\$SLURM_SUBMIT_DIR"
echo "Running Master"
cd ../master

echo "Running in $(pwd):"

job_slug="$job_slug"
Expand Down
Loading