Skip to content

Conversation

@ChrisZYJ
Copy link
Contributor

@ChrisZYJ ChrisZYJ commented Mar 28, 2025

Description

Set minimum policy version to 3.5 to fix FFTW compilation with CMake 4.0+.

See FFTW/fftw3#381

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Note

It still fails the tests where it needs to build the master branch. The log shows that FFTW in the PR branch is correctly built.

@ChrisZYJ ChrisZYJ requested a review from a team as a code owner March 28, 2025 05:23
@ChrisZYJ ChrisZYJ marked this pull request as draft March 28, 2025 05:39
@codecov
Copy link

codecov bot commented Mar 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 43.66%. Comparing base (700267d) to head (05d0abc).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #810   +/-   ##
=======================================
  Coverage   43.66%   43.66%           
=======================================
  Files          65       65           
  Lines       19159    19159           
  Branches     2338     2338           
=======================================
  Hits         8365     8365           
  Misses       9370     9370           
  Partials     1424     1424           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ChrisZYJ ChrisZYJ closed this Mar 28, 2025
@ChrisZYJ ChrisZYJ reopened this Apr 2, 2025
@ChrisZYJ ChrisZYJ changed the title Test PR: CI benchmark hypo_hll on master Test PR: Workflow FFTW bug Apr 2, 2025
@ChrisZYJ ChrisZYJ changed the title Test PR: Workflow FFTW bug Fix FFTW compilation bug Apr 3, 2025
@ChrisZYJ ChrisZYJ marked this pull request as ready for review April 3, 2025 03:22
@ChrisZYJ ChrisZYJ requested a review from a team as a code owner April 3, 2025 03:22
@ChrisZYJ ChrisZYJ closed this Apr 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant