Skip to content

Fix #797 #812

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 42 commits into from
Closed

Fix #797 #812

wants to merge 42 commits into from

Conversation

@dgvacarevelo
Copy link
Contributor

@dgvacarevelo dgvacarevelo commented Mar 31, 2025

Description

Removes 'stop' commands from the GPU regions, and relocate them in CPU regions.

Fixes #797

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Scope

  • This PR comprises a set of related changes with a common goal

Diego Vaca and others added 30 commits November 26, 2024 14:37
Lagrangian v2
29f5a8b
V2.1
d9c43b9
Lagrangian solver V2.2
eac5a05
Merge branch 'master' of https://github.com/MFlowCode/MFC into lagran…
fcdd2a4 
…gian

Lagrangian solver V2.3
lagrangian subgrid bubble model v2.4
c8ce640
Lagrangian subgrid model V2.5
bc95701
Lagrangian subgrid model v2.6
b6c7dc0
Lagrange bubble model fixing PR part 1
f49281b
Lagrange bubble model fixing PR part 1, solving test issue
85e3989
Lagrange bubble model fixing PR part 2
31e0944
Merge branch 'master' of https://github.com/MFlowCode/MFC into lagran…
d395686 
…gian

Pulling from master
@wilfonba
builds on frontier but doesn't run ):
bb77a24
@wilfonba
Merge remote-tracking branch 'upstream/master' into lagrangian
a8232ce
@wilfonba
fix test suite
736f8fc
@wilfonba
asdf
47bfb4b
fixing PR part 3
c2b40ec
fixing PR part 4
1fb0954
Lagrange bubbles fixing PR part 5
733fb17
Lagrange bubbles fixing tests
35d1889
EL intel fixed
9f0c644
@wilfonba
frontier changes
45da453
@wilfonba
Revert "frontier changes"
bd29644 
This reverts commit 45da453.
@wilfonba
update golden files for GPUs
ba6b901
@wilfonba
change rkck_adap_dt_tol
05ec6ee
@wilfonba
Revert "change rkck_adap_dt_tol"
521c163 
This reverts commit 05ec6ee.
@wilfonba
Revert "update golden files for GPUs"
9e4f009 
This reverts commit ba6b901.
solving adapt dt rkck
1fe925a
Merge branch 'lagrangian' of github.com:dgvacarevelo/MFC into lagrangian
958719a
Fixed GPUs testing NVIDIA and added wp PR
55e3efa
@sbryngelson
Update m_bubbles_EL_kernels.fpp
f2de459
@dgvacarevelo dgvacarevelo requested review from a team and sbryngelson as code owners March 31, 2025 23:23
@sbryngelson
Copy link
Member

sbryngelson commented Apr 1, 2025

Can you remove your changes to these other files or just cherry-pick your changes by making a new branch based on MFlowCode/MFC/master and copying the changes over there?

@sbryngelson
Copy link
Member

sbryngelson commented Apr 1, 2025 •
edited
Loading

some cases failing by default due to

 CASE FILE ERROR
   - Prohibited condition: lag_params%cluster_type<=0                                       
   - Note: cluster_type must be specified

@dgvacarevelo dgvacarevelo deleted the lagrangian branch May 20, 2025 00:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sbryngelson sbryngelson Awaiting requested review from sbryngelson sbryngelson is a code owner

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Cannot have stop in accelerator region

3 participants

@dgvacarevelo @sbryngelson @wilfonba