-
Notifications
You must be signed in to change notification settings - Fork 121
Frontier module update #842
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #842 +/- ##
==========================================
- Coverage 43.34% 43.24% -0.11%
==========================================
Files 68 68
Lines 20128 20182 +54
Branches 2400 2401 +1
==========================================
+ Hits 8725 8728 +3
- Misses 9934 9985 +51
Partials 1469 1469 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@wilfonba did you test that the CPU case works? If so, can you add it as a CI run? So each CI test run will run the CPU version and the GPU version. I'm realizing I'm ballooning your PR here, apologies. I've been wanting to do this for a while, actually. |
|
@sbryngelson Yeah, I can. No worries, shouldn't take long at all |
|
@sbryngelson I'll send a message when this is ready to merge. I was looking at the Frontier logs and noticed that both the CPU and GPU runners ran the CPU code due to an error I made in the workflow files, so I did what I think corrected that, but I'll have to wait for the runners. |
|
good find, thanks |
|
this appears to be working, ? |
|
@sbryngelson yep. Ready to merge now. I had to make a second change and let the runners go overnight. |
Description
Updates Frontier modules for CCE 19.0.X and the profiling updates.
Type of change
Please delete options that are not relevant.
Scope
How Has This Been Tested?
Ran
./mfc.sh run examples/3D_performance_test/case.py -c frontier -n 1./mfc.sh run examples/3D_performance_test/case.py -c frontier -# PERF_Test -n 1 --rcu./mfc.sh run examples/3D_performance_test/case.py -c frontier --rsysand all worked as expected.