-
Notifications
You must be signed in to change notification settings - Fork 121
Frontier Benchmarking (#453) #881
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 2 commits
Commits
Show all changes
41 commits
Select commit
Hold shift + click to select a range
bac5df7
Frontier Benchmarking (#453)
819e599
fixed frontier setup
17db70d
reduced frontier to bench on GPU
Malmahrouqi3 b28167f
updated frontier job instructions
Malmahrouqi3 ae04e14
fixed syntax in ymal file
Malmahrouqi3 8fb75b6
matrix.device synatx error addressed
Malmahrouqi3 57da396
another fix
Malmahrouqi3 0432f1f
fix
Malmahrouqi3 08052ea
matrix.device
Malmahrouqi3 b66403b
removed matrix.device - flatened
Malmahrouqi3 e49d55f
removed leading to syntax error
Malmahrouqi3 03034d7
replaced matrix.name to matrix.cluster to avoid syntax error
Malmahrouqi3 02688d9
Update bench.yml
Malmahrouqi3 c6258a6
just some ()
Malmahrouqi3 11fcf9e
Merge branch 'master' into frontier-CI2
Malmahrouqi3 4cbab63
Update bench.yml
Malmahrouqi3 51d34ae
Merge branch 'master' into frontier-CI2
sbryngelson a8268f3
Update submit-bench.sh
sbryngelson 8dcf100
Update submit-bench.sh
Malmahrouqi3 bde0c17
Merge branch 'master' into frontier-CI2
sbryngelson def52bc
Merge branch 'master' into frontier-CI2
sbryngelson 88fcf35
Merge branch 'master' into frontier-CI2
sbryngelson ea02640
Merge branch 'master' into frontier-CI2
sbryngelson f705d7f
Normalize line endings to UNIX format
Malmahrouqi3 53eec50
removed commented Phoenix part
Malmahrouqi3 93e0fac
removed file changes check
Malmahrouqi3 c7360eb
undo phoenix stuff
Malmahrouqi3 cc318bc
Revert "undo phoenix stuff"
Malmahrouqi3 5c8b925
Revert "Normalize line endings to UNIX format"
Malmahrouqi3 3c06357
some stuff
Malmahrouqi3 c6b1ecf
removed parts
Malmahrouqi3 3317bdb
Revert "Update submit-bench.sh"
Malmahrouqi3 27aa35b
undo things in test.yml
Malmahrouqi3 77b30e3
Merge branch 'master' into frontier-CI2
Malmahrouqi3 6158e12
fixing
sbryngelson 5c6acc0
add build script
wilfonba 32a8292
Merge branch 'master' into frontier-CI2
sbryngelson b842f21
Merge branch 'master' into frontier-CI2
sbryngelson 405c39c
Update bench.yml
sbryngelson 98437d2
Update submit-bench.sh
sbryngelson e7e7de8
Update bench.sh
sbryngelson File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,21 @@ | ||
| #!/bin/bash | ||
|
|
||
| n_ranks=12 | ||
|
|
||
| if [ "$job_device" == "gpu" ]; then | ||
| gpus=$(rocm-smi --showid | awk '{print $1}' | grep -Eo '[0-9]+' | uniq | tr '\n' ' ') | ||
| n_ranks=$(echo "$gpus" | wc -w) # number of GPUs on node | ||
| gpu_ids=$(echo "$gpus" | tr ' ' '\n' | tr '\n' ' ' | sed 's/ $//') # GPU IDs from rocm-smi | ||
| device_opts="--gpu -g $gpu_ids" | ||
| fi | ||
|
|
||
| mkdir -p /storage/scratch1/6/sbryngelson3/mytmp_build | ||
| export TMPDIR=/storage/scratch1/6/sbryngelson3/mytmp_build | ||
sbryngelson marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
|
|
||
| if [ "$job_device" == "gpu" ]; then | ||
| ./mfc.sh bench --mem 12 -j $n_ranks -o "$job_slug.yaml" -- -c frontier-bench $device_opts -n $n_ranks | ||
| else | ||
| ./mfc.sh bench --mem 1 -j $(nproc) -o "$job_slug.yaml" -- -c frontier-bench $device_opts -n $n_ranks | ||
sbryngelson marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| fi | ||
|
|
||
| unset TMPDIR | ||
sbryngelson marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,56 @@ | ||
| #!/bin/bash | ||
|
|
||
| set -e | ||
|
|
||
| usage() { | ||
| echo "Usage: $0 [script.sh] [cpu|gpu]" | ||
| } | ||
|
|
||
| if [ ! -z "$1" ]; then | ||
| sbatch_script_contents=`cat $1` | ||
| else | ||
| usage | ||
| exit 1 | ||
| fi | ||
|
|
||
| if [ "$2" == "cpu" ]; then | ||
| sbatch_device_opts="\ | ||
| #SBATCH -n 32 # Number of cores required" | ||
| elif [ "$2" == "gpu" ]; then | ||
| sbatch_device_opts="\ | ||
| #SBATCH -n 8 # Number of cores required" | ||
| else | ||
| usage | ||
| exit 1 | ||
| fi | ||
|
|
||
|
|
||
| job_slug="`basename "$1" | sed 's/\.sh$//' | sed 's/[^a-zA-Z0-9]/-/g'`-$2" | ||
sbryngelson marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
|
||
| sbatch <<EOT | ||
| #!/bin/bash | ||
| #SBATCH -JMFC-$job_slug # Job name | ||
| #SBATCH -A CFD154 # charge account | ||
| #SBATCH -N 1 # Number of nodes required | ||
| $sbatch_device_opts | ||
| #SBATCH -t 01:59:00 # Duration of the job (Ex: 15 mins) | ||
| #SBATCH -o$job_slug.out # Combined output and error messages file | ||
| #SBATCH -p extended # Extended partition for shorter queues | ||
| #SBATCH -q debug # Use debug QOS - only one job per user allowed in queue! | ||
| #SBATCH -W # Do not exit until the submitted job terminates. | ||
|
|
||
| set -e | ||
| set -x | ||
|
|
||
| cd "\$SLURM_SUBMIT_DIR" | ||
| echo "Running in $(pwd):" | ||
|
|
||
| job_slug="$job_slug" | ||
| job_device="$2" | ||
|
|
||
| . ./mfc.sh load -c f -m g | ||
|
|
||
| $sbatch_script_contents | ||
|
|
||
| EOT | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.