Skip to content

Conversation

@XZTian64
Copy link
Collaborator

@XZTian64 XZTian64 commented Jun 19, 2025

Description

Add a regex check for those integers. To make sure the numbers in the format of X_wp are real numbers.

Closes #885

Type of change

Please delete options that are not relevant.

  • Double-checked the 1_wp numbers, made all of those real type.
  • Add a grep command (in lint-source.yml) to find the wrong integers.
  • Something else

Scope

  • This PR comprises a set of related changes with a common goal

If you cannot check the above box, please split your PR into multiple PRs that each have a common goal.

How Has This Been Tested?

Please describe the tests that you ran to verify your changes.
Provide instructions so we can reproduce.
Please also list any relevant details for your test configuration

  • Test A
  • Test B

Test Configuration:

  • What computers and compilers did you use to test this:

Checklist

  • I have added comments for the new code
  • I added Doxygen docstrings to the new code
  • I have made corresponding changes to the documentation (docs/)
  • I have added regression tests to the test suite so that people can verify in the future that the feature is behaving as expected
  • I have added example cases in examples/ that demonstrate my new feature performing as expected.
    They run to completion and demonstrate "interesting physics"
  • I ran ./mfc.sh format before committing my code
  • New and existing tests pass locally with my changes, including with GPU capability enabled (both NVIDIA hardware with NVHPC compilers and AMD hardware with CRAY compilers) and disabled
  • This PR does not introduce any repeated code (it follows the DRY principle)
  • I cannot think of a way to condense this code and reduce any introduced additional line count

If your code changes any code source files (anything in src/simulation)

To make sure the code is performing as expected on GPU devices, I have:

  • Checked that the code compiles using NVHPC compilers
  • Checked that the code compiles using CRAY compilers
  • Ran the code on either V100, A100, or H100 GPUs and ensured the new feature performed as expected (the GPU results match the CPU results)
  • Ran the code on MI200+ GPUs and ensure the new features performed as expected (the GPU results match the CPU results)
  • Enclosed the new feature via nvtx ranges so that they can be identified in profiles
  • Ran a Nsight Systems profile using ./mfc.sh run XXXX --gpu -t simulation --nsys, and have attached the output file (.nsys-rep) and plain text results to this PR
  • Ran a Rocprof Systems profile using ./mfc.sh run XXXX --gpu -t simulation --rsys --hip-trace, and have attached the output file and plain text results to this PR.
  • Ran my code using various numbers of different GPUs (1, 2, and 8, for example) in parallel and made sure that the results scale similarly to what happens if you run without the new code/feature

@XZTian64 XZTian64 requested review from a team and sbryngelson as code owners June 19, 2025 05:51
@codecov
Copy link

codecov bot commented Jun 19, 2025

Codecov Report

Attention: Patch coverage is 37.85714% with 87 lines in your changes missing coverage. Please review.

Project coverage is 45.76%. Comparing base (2aad1d4) to head (65e413e).
Report is 4 commits behind head on master.

Files with missing lines Patch % Lines
src/simulation/m_riemann_solvers.fpp 50.00% 24 Missing ⚠️
src/pre_process/m_patches.fpp 0.00% 14 Missing and 8 partials ⚠️
src/post_process/m_derived_variables.fpp 0.00% 7 Missing ⚠️
src/simulation/m_bubbles_EE.fpp 0.00% 6 Missing ⚠️
src/simulation/m_cbc.fpp 33.33% 4 Missing ⚠️
src/simulation/m_pressure_relaxation.fpp 20.00% 4 Missing ⚠️
src/simulation/m_rhs.fpp 0.00% 4 Missing ⚠️
src/common/m_variables_conversion.fpp 50.00% 3 Missing ⚠️
src/pre_process/m_grid.f90 0.00% 3 Missing ⚠️
src/pre_process/m_assign_variables.fpp 0.00% 2 Missing ⚠️
... and 5 more
Additional details and impacted files
@@           Coverage Diff           @@
##           master     #893   +/-   ##
=======================================
  Coverage   45.76%   45.76%           
=======================================
  Files          68       68           
  Lines       18668    18668           
  Branches     2251     2251           
=======================================
  Hits         8543     8543           
  Misses       8767     8767           
  Partials     1358     1358           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sbryngelson
Copy link
Member

Very good! This closes #885 . Merging.

@sbryngelson sbryngelson merged commit 59d0c09 into MFlowCode:master Jun 20, 2025
43 of 51 checks passed
prathi-wind pushed a commit to prathi-wind/MFC-prathi that referenced this pull request Jul 13, 2025
Co-authored-by: Xuzheng Tian <[email protected]>
Co-authored-by: Spencer Bryngelson <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

Need to catch 1_wp style problems

2 participants