Skip to content

fixes an issue with macro directives for !$acc kernels #926

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 8, 2025
Merged

fixes an issue with macro directives for !$acc kernels #926

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions src/simulation/m_data_output.fpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -316,14 +316,14 @@
Rc_min_loc = minval(Rc_sf)
end if
#else
#:call GPU_PARALLEL()
icfl_max_loc = maxval(icfl_sf)
#:endcall GPU_PARALLEL
!$acc kernels
icfl_max_loc = maxval(icfl_sf)
!$acc end kernels
if (viscous) then
#:call GPU_PARALLEL()
vcfl_max_loc = maxval(vcfl_sf)
Rc_min_loc = minval(Rc_sf)
#:endcall GPU_PARALLEL
!$acc kernels
vcfl_max_loc = maxval(vcfl_sf)
Rc_min_loc = minval(Rc_sf)

Check warning on line 325 in src/simulation/m_data_output.fpp

View check run for this annotation

Codecov / codecov/patch

src/simulation/m_data_output.fpp#L324-L325 

Added lines #L324 - L325 were not covered by tests
!$acc end kernels
end if
#endif

Expand Down
6 changes: 3 additions & 3 deletions src/simulation/m_time_steppers.fpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -993,9 +993,9 @@ contains
end do
end do

#:call GPU_PARALLEL()
dt_local = minval(max_dt)
#:endcall GPU_PARALLEL
!$acc kernels
dt_local = minval(max_dt)
!$acc end kernels

if (num_procs == 1) then
dt = dt_local
Expand Down
Loading