-
Notifications
You must be signed in to change notification settings - Fork 121
Remove fortitude from workflow #986
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR removes the fortitude-lint dependency and associated linting workflow due to installation difficulties on macOS. The change simplifies the toolchain by eliminating a problematic dependency while retaining other code quality checks.
Key changes:
- Removed
fortitude-lintfrom Python dependencies - Eliminated the fortitude linting step from the CI workflow
- Deleted the fortitude configuration file
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| toolchain/pyproject.toml | Removed fortitude-lint from the dependencies list |
| .github/workflows/lint-source.yml | Removed the fortitude linting job from the CI workflow |
| .fortitude.toml | Deleted the entire fortitude configuration file |
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
PR Code Suggestions ✨Explore these optional code suggestions:
|
|||||||||
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #986 +/- ##
=======================================
Coverage 40.93% 40.93%
=======================================
Files 70 70
Lines 20288 20288
Branches 2517 2517
=======================================
Hits 8305 8305
Misses 10447 10447
Partials 1536 1536 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
User description
deleted fortitude. pain to install for some users on macos
PR Type
Other
Description
Remove fortitude linting tool from project
Delete configuration file and workflow steps
Update Python dependencies in pyproject.toml
Diagram Walkthrough
File Walkthrough
.fortitude.toml
Delete fortitude configuration file.fortitude.toml
lint-source.yml
Remove fortitude from CI workflow.github/workflows/lint-source.yml
pyproject.toml
Remove fortitude dependencytoolchain/pyproject.toml
fortitude-lintfrom dependencies list