Skip to content

--rdma-mpi flag fix #996

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Sep 15, 2025
Merged

--rdma-mpi flag fix #996

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
b0ea72d
updated fixes
Sep 7, 2025
fa58f9b
improvement
Sep 7, 2025
98b4e4a
workflow files
Sep 7, 2025
e7348b5
re-generated golden file
Sep 8, 2025
0518a4f
Merge branch 'master' into RDMA-fix
Malmahrouqi3 Sep 8, 2025
07d217b
added -a for post_process testing
Sep 10, 2025
6c4e8cf
Merge branch 'master' into RDMA-fix
Malmahrouqi3 Sep 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/frontier/build.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,6 @@ if [ "$2" == "bench" ]; then
./mfc.sh run "$dir/case.py" --case-optimization -j 8 --dry-run $build_opts
done
else
./mfc.sh test -a --dry-run --rdma-mpi --generate -j 8 $build_opts
./mfc.sh test --dry-run --rdma-mpi -j 8 $build_opts
fi

4 changes: 2 additions & 2 deletions .github/workflows/frontier/test.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ gpus=`rocm-smi --showid | awk '{print $1}' | grep -Eo '[0-9]+' | uniq | tr '\n'
ngpus=`echo "$gpus" | tr -d '[:space:]' | wc -c`

if [ "$job_device" = "gpu" ]; then
./mfc.sh test -a --rdma-mpi --max-attempts 3 -j $ngpus -- -c frontier
./mfc.sh test --rdma-mpi --max-attempts 3 -j $ngpus -- -c frontier
else
./mfc.sh test -a --rdma-mpi --max-attempts 3 -j 32 -- -c frontier
./mfc.sh test --max-attempts 3 -j 32 -- -c frontier
Copy link
Member

@sbryngelson sbryngelson Sep 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you removed testing of post_process on frontier (that's what -a does). please put it back 😄

fi
189 changes: 189 additions & 0 deletions tests/1B300F28/golden-metadata.txt
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

20 changes: 20 additions & 0 deletions tests/1B300F28/golden.txt
View file
Open in desktop

Large diffs are not rendered by default.

189 changes: 189 additions & 0 deletions tests/2C9844EF/golden-metadata.txt
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

23 changes: 23 additions & 0 deletions tests/2C9844EF/golden.txt
View file
Open in desktop

Large diffs are not rendered by default.

Loading
Loading