fix: enhance WebSocket stability, resolve XHTTP configurations and fix UI loading shifts#3997
Open
lolka1333 wants to merge 7 commits intoMHSanaei:mainfrom
Open
fix: enhance WebSocket stability, resolve XHTTP configurations and fix UI loading shifts#3997lolka1333 wants to merge 7 commits intoMHSanaei:mainfrom
lolka1333 wants to merge 7 commits intoMHSanaei:mainfrom
Conversation
…igh-performance WebSocket hub and background job system
1. **Fixed XPadding Placement Dropdown**: - Added the missing `cookie` and `query` options to `xPaddingPlacement` (`stream_xhttp.html`). - *Why:* Previously, users wanting `cookie` obfuscation were forced to use the `header` placement string. This caused Xray-core to blindly intercept the entire monolithic HTTP Cookie header, failing internal padding-length validations and causing the inbound to silently drop the connection. 2. **Fixed Uplink Data Placement Validation**: - Replaced the unsupported `query` option with `cookie` in `uplinkDataPlacement`. - *Why:* Xray-core's `transport_internet.go` explicitly forbids `query` as an uplink placement option. Selecting it from the UI previously sent a payload that would cause Xray-core to instantly throw an `unsupported uplink data placement: query` panic. Adding `cookie` perfectly aligns the UI with Xray-core restrictions. ### Related Issues - Resolves MHSanaei#3992
…ctioning correctly and eliminates WebSocket log spam. - **[Fix X-Padding UI]** Added missing `cookie` and `query` options to X-Padding Placement. Fixes the issue where using Cookie fallback triggers whole HTTP Cookie header interception and silent drop in Xray-core. (Resolves [MHSanaei#3992](MHSanaei#3992)) - **[Fix Uplink Data Options]** Replaced the invalid `query` option with `cookie` in Uplink Data Placement dropdown to prevent Xray-core backend panic `unsupported uplink data placement: query`. - **[Fix WebSockets Spam]** Boosted `maxMessageSize` boundary to 100MB and gracefully handled fallback fetch signals via `broadcastInvalidate` to avoid buffer dropping spam. (Resolves [MHSanaei#3984](MHSanaei#3984))
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the pull request?
This PR is a comprehensive update that addresses several critical functional and UI/UX issues across the panel:
100MBnatively, and introducing a graceful fallback signal (broadcastInvalidate) which elegantly instructs the frontend to re-fetch via REST APIs if a WebSocket message is still structurally too large.xPaddingPlacementanduplinkDataPlacementwithinstream_xhttp.html. Previously absentcookieandqueryoptions caused the UI to send invalid payloads that forcedXray-coreinto throwingunsupported uplink data placementpanics or intercepting monolithic HTTP headers.inbounds.htmlpage where full-table re-renders (like executing client toggle actions) forced the CSS<a-spin>to violently jump out of the wrapper due to instantaneous array splicing (splice(0)). The master loading spinner is now physically locked and perfectly centered relative to the layout via specific fixed CSS.Which part of the application is affected by the change?
Type of Changes
Screenshots