remove dependencies unittest2 and future #130
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… Python 2 and Python 3)
Author
|
Also removed setup.cfg. It was specifying the description (readme file), but this is already included in the pyproject.toml. |
10 tasks
|
A recent vulnerability was found in the future package as well: GHSA-xqrq-4mgf-ff32 This PR (and a release) would resolve this security issue. |
|
If the unittest changes need further review and/or testing, let me know so that I can open a PR that simply removes the future package dependency as this is a critical vulnerability. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #77.
Remove dependency to unittest2 and future.
I also slightly modernized the package. All configuration settings are now in a
pyproject.toml.I ran the tests locally and they pass: