Sequential Inference (Non-MP)#2705
Merged
FabianIsensee merged 2 commits intoMIC-DKFZ:masterfrom Jun 2, 2025
Merged
Conversation
Contributor
Author
|
@FabianIsensee, did you find a moment to look into this? The changes are minimal but necessary to use your new sequential function from the CLI. Let me know if there's anything I can do to expedite the process or assist in any other way. Once resolved, we can proceed with implementing the following models: |
Contributor
Author
|
@FabianIsensee Hi Fabian, I know times are busy. This PR includes minimal changes to enable the use of your new non-parallel inference from the CLI. I would appreciate it if you could take a quick look or suggest a rough timeline. Thank you and best, Leo. |
Member
|
Hey, sorry for being so slow 😅. Looks great, thank you for this addition! Many will be happy to have this! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR resolves #2556.
Improved implementation following #2614.
nnUNet_nppandnnUNet_npsto set-nppand-npsuse predict_from_files_sequentialfunctionWe have done some internal testing and get identical results between the latest
nnunetv2==2.5.1and with our proposed patch.