fix copying dataset.json to output_folder in ensemble_folders function
#2857
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r_dict` is specified
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix changes how the dataset.json file is written to the output folder.
The old implementation tries to copy the file at the path
join(list_of_input_folders[0], 'dataset.json'. Whendataset_json_file_or_dictis specified, the file at this path is probably not intended to be used byensemble_foldersor may not even exist. The new implementation dumps thedataset_jsonobject instead to ensureensemble_folderswrites the correct dataset.json data to the output folder whetherdataset_json_file_or_dictis None, a file path, or a dictionary.