-
Notifications
You must be signed in to change notification settings - Fork 2.3k
Log actual augmentation transforms in debug.json #2973
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Co-authored-by: TaWald <[email protected]>
Co-authored-by: TaWald <[email protected]>
Co-authored-by: TaWald <[email protected]>
TaWald
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Included the proposed changes to log the augmentation pipeline parameters.
|
PR of #2933 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adds details of training and validation augmentation pipeline to debug.json
_save_debug_information()was logging"dataloader_train.transform": "None"despite augmentations being applied. The transforms are actually stored indataloader.generator.transforms, not at the top level.Changes:
generator.transformswhen present on dataloadersdlinstead of repeatedgetattr(self, k)callsResult:
{ "dataloader_train.generator.transforms": "ComposeTransforms( transforms = [SpatialTransform(...), GaussianNoiseTransform(...), ...])", "dataloader_train.transform": "None" }Original prompt
This section details on the original issue you should resolve
<issue_title>_save_debug_information() prints "dataloader_train.transform": "None" everytime despite augmentation applied</issue_title>
<issue_description>As in the title, the debug transform info is always set to None.
I modified the debug function to print the actual augmentations applied. Figured it would be useful to someone else, especially when you're playing around with the augmentations its useful to log them:
Add one extra check in _save_debug_information() to include the internal data loader’s transforms:
nnUNet/nnunetv2/training/nnUNetTrainer/nnUNetTrainer.py
Lines 281 to 287 in 86606c5
Suggested edit:
So previously in the debug.json I would get:
Now I get:
</issue_description>
<agent_instructions>Create a PR that includes the suggested edit.</agent_instructions>
Comments on the Issue (you are @copilot in this section)
@TaWald Hey @anan1504 Thanks for this, it ...💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.