Conversation
|
svelte-maplibre-gl
@svelte-maplibre-gl/contour
@svelte-maplibre-gl/deckgl
@svelte-maplibre-gl/pmtiles
@svelte-maplibre-gl/terradraw
commit: |
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
svelte-maplibre-gl | 7a57326 | Commit Preview URL Branch Preview URL |
Jan 28 2026, 04:21 AM |
There was a problem hiding this comment.
Pull request overview
Updates the workspace tooling dependencies to move the docs workspace onto Vite 7.3.1 (and related lockfile refresh).
Changes:
- Bump Vite from
^6.4.1to^7.3.1in the pnpm catalog and lockfile. - Bump Svelte from
5.39.7to^5.48.5in the pnpm catalog and lockfile. - Adjust MapLibre GL version specifiers (catalog and root package) and regenerate portions of the lockfile.
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| pnpm-workspace.yaml | Updates catalog versions (Vite/Svelte/MapLibre GL) used across the workspace. |
| pnpm-lock.yaml | Reflects the updated resolved versions for Vite/Svelte and associated dependency graph changes. |
| package.json | Pins maplibre-gl version in the root docs package. |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
pnpm-workspace.yaml
Outdated
| '@types/geojson': ^7946.0.16 | ||
| maplibre-contour: ^0.1.0 | ||
| maplibre-gl: 5.17.0 | ||
| maplibre-gl: ^5.17.0 |
There was a problem hiding this comment.
maplibre-gl is set to ^5.17.0 in the workspace catalog, but the lockfile’s catalogs.default.maplibre-gl.specifier is still 5.17.0 (no caret). This mismatch will cause pnpm install to rewrite the lockfile. Either revert the catalog entry back to an exact 5.17.0 or regenerate the lockfile after changing the catalog specifier.
| maplibre-gl: ^5.17.0 | |
| maplibre-gl: 5.17.0 |
| pmtiles: ^4.3.2 | ||
| publint: ^0.3.17 | ||
| svelte: 5.39.7 | ||
| svelte: ^5.48.5 |
There was a problem hiding this comment.
The PR title only mentions upgrading Vite, but this change also upgrades the catalog svelte version (5.39.7 → 5.48.5). Please either update the PR title/description to reflect the Svelte upgrade, or split this into a separate PR so dependency bumps are scoped and easier to review/revert.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a6131472a4
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
No description provided.