Skip to content

Add a check if MISPObject.add_attributes() method has truly values to add #1320

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Rafiot merged 2 commits into from
Mar 24, 2025
Merged

Add a check if MISPObject.add_attributes() method has truly values to add #1320

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
157b603
Add a check if add_attributes() method truly has values to add
not4Pedro Mar 20, 2025
fb9d4ff
Improve the logging message
not4Pedro Mar 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions pymisp/mispevent.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1121,6 +1121,11 @@ def add_attributes(self, object_relation: str, *attributes: Sequence[str | dict[
It is the same as calling multiple times add_attribute with the same object_relation.
'''
to_return = []

if not attributes:
logger.warning(f"No attributes provided for object relation '{object_relation}'; skipping attribute addition.")
return to_return

for attribute in attributes:
if isinstance(attribute, MISPAttribute):
a = self.add_attribute(object_relation, **attribute.to_dict())
Expand Down
Loading