Skip to content

Allow passwordless Redis connections #300

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Allow passwordless Redis connections #300

wants to merge 3 commits into from

Conversation

damanzanofortra
Copy link
Contributor

Potential solution for #299

ostefano
ostefano requested changes Sep 12, 2025
View reviewed changes
Copy link
Collaborator

@ostefano ostefano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would allow a guard, like a variable REDIS_ENABLE_EMPTY_PASSWORD that if true will allow empty password. Maybe ENABLE_REDIS_EMPTY_PASSWORD better.

@ostefano ostefano added enhancement New feature or request question Further information is requested labels Sep 12, 2025
@damanzanofortra
Copy link
Contributor Author

Perfect, let me implement that suggestion

@damanzanofortra
Copy link
Contributor Author

@ostefano just added the requested guard, and update local dev tools in case someone wants to use the local redis passwordless. Please let me know if there's anything else that should be updated.

ostefano
ostefano reviewed Sep 18, 2025
View reviewed changes
Copy link
Collaborator

@ostefano ostefano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but will need to test it a bit

@ostefano ostefano self-requested a review September 18, 2025 11:37
@ostefano ostefano linked an issue Sep 18, 2025 that may be closed by this pull request
Redis configuration doesn't support password-less redis #299
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ostefano ostefano Awaiting requested review from ostefano

Assignees

@damanzanofortra damanzanofortra

Labels
enhancement New feature or request question Further information is requested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Redis configuration doesn't support password-less redis
2 participants
@damanzanofortra @ostefano