Make training an optional field

[Chrystinne]

This PR allows the waiving of training submissions for credentialed access type. This modification has been implemented to support the release of the Bridge2AI project.

The PR modifies the handling of required trainings for credentialed access policy in the AccessMetadataForm.

The empty_field option doesn't work for the current AccessMetadataForm as it triggers the error "" is not a valid value (see image below):

To fix that issue, we needed to add a custom CustomModelMultipleChoiceField to allow 'No training required' as a valid option to be selected by the authors when no training is required.

All the following tests passed:

1. Creation and publication of a new project P1 with credentialed access type with no training required, and testing the access with different types of users:

   • User 1 with credentialing = False and training = False
   • User 2 with credentialing = True and training = True
   • User 3 with credentialing = True and training = False
   • User 4 with credentialing = False and training = True

2. Creation and publication of a new project P2 with credentialed access type with CITI training required, and testing the access with different types of users:

   • User 1 with credentialing = False and training = False
   • User 2 with credentialing = True and training = True
   • User 3 with credentialing = True and training = False
   • User 4 with credentialing = False and training = True

3. Creation and publication of a new version of project P1 keeping the same information as the previous version, and testing the access with different types of users:

   • User 2 with credentialing = True and training = True
   • User 3 with credentialing = False and training = False

4. Creation and publication of a new version of project P2 keeping the same information as the previous version, and testing the access with different types of users:

   • User 2 with credentialing = True and training = True
   • User 3 with credentialing = False and training = False

5. Creation and publication of a new version of project P1 changing the information of the previous version (i.e., required training information), and testing the access with different types of users:

   • User 2 with credentialing = True and training = True
   • User 3 with credentialing = False and training = False

6. Creation and publication of a new version of project P2 changing the information of the previous version (i.e., required training information), and testing the access with different types of users:

   • User 2 with credentialing = True and training = True
   • User 3 with credentialing = False and training = False

[tompollard]

The logic here could be clearer. It's unclear how the current set of statements are organised. My preference would be a set of if else statements, working through each access policy, e.g.

if open: do x
elif restricted: do y
etc

[Chrystinne]

@tompollard, I've modified the code to preselect the "No training required" option when the field is empty or was previously set to no training.

Now it appears like this when editing a project that does not require training:

[tompollard]

Looks good to me @Chrystinne. One minor thing is that the published project includes an empty "Training required:" section.

This section should either:

1. Not be displayed if there are no training requirements, or
2. It should say something like "None required" or "No training required".

[Chrystinne]

@tompollard Thanks, Tom. I've updated this section to display "No training required" if there are no training requirements:

[tompollard]

Thanks Chrystinne, looks good to me!