Allow creating a new version after previous submission is archived#2382
Merged
Allow creating a new version after previous submission is archived#2382
Conversation
Authors are not allowed to create two active versions of the same core project at a time; if a project has an active version, the "New Version" button should not be shown, and new_project_version should reject the request. Whether an author is allowed to create a new version is determined by PublishedProject.can_publish_new, which invokes CoreProject.active_new_version to determine whether there's an existing ActiveProject. Originally, when an active project was "deleted" or rejected, the ActiveProject object was deleted and an ArchivedProject object created to replace it. So afterwards, the author could go back and create a new active version from scratch. However, archived projects are now a subcategory of ActiveProjects. Since they should not be counted as "being worked on", a deleted/rejected submission should not prevent the author from creating a new submission.
Member
|
Looks good to me, thanks for fixing this. |
tompollard
approved these changes
Apr 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If you are the submitting author of a published project:
Likewise, if you create a new version and submit it, and it is rejected, you will be incapable of creating another new version.
This was an unintended consequence of adding ARCHIVED as a submission status and removing ArchivedProjects (see pull #2149 and #2170).